From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH 4/5] gnu: Add syslinux. Date: Fri, 10 Feb 2017 15:24:09 +0100 Message-ID: References: <20170209190450.29458-1-david@craven.ch> <20170209190450.29458-7-david@craven.ch> <87d1eqsv1u.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccC7S-0003SW-RM for guix-devel@gnu.org; Fri, 10 Feb 2017 09:24:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccC7O-0007IR-TW for guix-devel@gnu.org; Fri, 10 Feb 2017 09:24:14 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:36020) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ccC7O-0007IM-ON for guix-devel@gnu.org; Fri, 10 Feb 2017 09:24:10 -0500 Received: by mail-qt0-x241.google.com with SMTP id h53so4685586qth.3 for ; Fri, 10 Feb 2017 06:24:10 -0800 (PST) In-Reply-To: <87d1eqsv1u.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel > I think the most common convention is to use the latest upstream > release, and adding revisions on top of it. But no strong opinion. > I tried packaging 6.03 a while back and it was very difficult. Most if > the problems seems to be solved here, so thanks for doing this. In general I agree, but I found 6.03 to be hard to package. Maybe I could try again now that something is building, but I expect that it would need additional patches. And 6.03 is very old. > This is unfortunate. The "unittest" target is applied recursively, and > fails with "no such target" in one of the folders. > > However, I was able to successfully run the tests by calling the > "unittest" target "manually" for some reason, like so: Thank you! This works well. > This software bundles some third-party code in the "com32" folder. > libpng@1.2, zlib, and others. Their licenses should be mentioned > here. Preferably they would be scrubbed from the source in favor of > system versions, but that looks to be difficult. Done.