From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input. Date: Sat, 10 Jan 2015 12:15:56 +0100 Message-ID: References: <87oaqxqn2h.fsf@gnu.org> <87zj9uz6z2.fsf@gnu.org> <87y4pd57o9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c34730b83d7b050c4a65ba Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9u1Q-0000aO-P6 for guix-devel@gnu.org; Sat, 10 Jan 2015 06:16:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9u1P-00088C-ES for guix-devel@gnu.org; Sat, 10 Jan 2015 06:16:00 -0500 In-Reply-To: <87y4pd57o9.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel --001a11c34730b83d7b050c4a65ba Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Jan 8, 2015 at 9:39 PM, Ludovic Court=C3=A8s wrote: > That said, this kind of patch is not very different from the automated > shebang patching that we do, IMO. I do not see it this way because the shebang concept is fully standardized, while here we are patching a "random" piece of code. > The reason I=E2=80=99m not thrilled by the use of =E2=80=98propagated-inp= uts=E2=80=99 here is > that that=E2=80=99s not what they were designed for at the beginning. > > It may also lead to usability problems. Remember that when A is a > propagated input of B, installing B in a profile also installs A in that > profile. So, if each GTKish package propagates sound-theme-freedesktop, > then installing several such packages in the same profile is likely to > lead to collisions just because the themes differ (those collisions may > be harmless, but they will at least trigger a bunch of warnings every > time the user operates on their profile, which is not desirable.) Thanks for explaining your concern. But doesn't this problem exist with most uses of propagated-inputs? As one example libssh2 propagates libgcrypt. If the user installs a different version of libgcrypt (with a possibly different ABI), doesn't this causes problems (required version not found, or worse)? In any case I've updated libcanberra with a patch to find the default sounds without the need for propagated-inputs. Differently from your suggested patch I'm proposing to add the default sounds store directory to the code dealing with XDG_DATA_DIRS. This is because XDG_DATA_HOME can only be a single directory and is inspected first. XDG_DATA_DIRS can list an arbitrary number of directories and is only inspected later. This is designed to allows the user to modify any theme at his pleasure. Regards, Fede --001a11c34730b83d7b050c4a65ba Content-Type: text/x-patch; charset=US-ASCII; name="0003-gnu-libcanberra-Add-default-sounds-support.patch" Content-Disposition: attachment; filename="0003-gnu-libcanberra-Add-default-sounds-support.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i4qv83kc0 RnJvbSBhMWQ3YTViOWVkMTM5MmQ4YzVjMWE4NTYxMzU3YjcyZTQ4MjUzY2NmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBCZWZmYSA8YmVmZmFAZmJlbmdpbmVlcmluZy5j aD4KRGF0ZTogVGh1LCAxOCBEZWMgMjAxNCAyMTozMjozNCArMDEwMApTdWJqZWN0OiBbUEFUQ0gg My80XSBnbnU6IGxpYmNhbmJlcnJhOiBBZGQgZGVmYXVsdCBzb3VuZHMgc3VwcG9ydC4KCiogZ251 L3BhY2thZ2VzL2xpYmNhbmJlcnJhLnNjbSAobGliY2FuYmVycmEpOiBBZGQgaW5wdXQKICAnc291 bmQtdGhlbWUtZnJlZWRlc2t0b3AnLiAgQWRkIHBoYXNlICdwYXRjaC1kZWZhdWx0LXNvdW5kcy1k aXJlY3RvcnkgdG8KICBwYXRjaCB0aGUgZGVmYXVsdCBzb3VuZHMgZGlyZWN0b3J5LgotLS0KIGdu dS9wYWNrYWdlcy9saWJjYW5iZXJyYS5zY20gfCAyOSArKysrKysrKysrKysrKysrKysrKysrKysr KysrLQogMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvbGliY2FuYmVycmEuc2NtIGIvZ251L3BhY2thZ2VzL2xp YmNhbmJlcnJhLnNjbQppbmRleCA3NjRjMzI3Li45MTc2MGQ4IDEwMDY0NAotLS0gYS9nbnUvcGFj a2FnZXMvbGliY2FuYmVycmEuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9saWJjYW5iZXJyYS5zY20K QEAgLTU1LDkgKzU1LDM2IEBACiAgICAgICAgKCJsaWJ0b29sIiAsbGlidG9vbCkKICAgICAgICAo ImxpYnZvcmJpcyIgLGxpYnZvcmJpcykKICAgICAgICAoInB1bHNlYXVkaW8iICxwdWxzZWF1ZGlv KQotICAgICAgICgidWRldiIgLGV1ZGV2KSkpCisgICAgICAgKCJ1ZGV2IiAsZXVkZXYpCisgICAg ICAgKCJzb3VuZC10aGVtZS1mcmVlZGVza3RvcCIgLHNvdW5kLXRoZW1lLWZyZWVkZXNrdG9wKSkp CiAgICAgKG5hdGl2ZS1pbnB1dHMKICAgICAgYCgoInBrZy1jb25maWciICxwa2ctY29uZmlnKSkp CisgICAgOzsgInNvdW5kLXRoZW1lLWZyZWVkZXNrdG9wIiBpcyB0aGUgZGVmYXVsdCBhbmQgZmFs bC1iYWNrIHNvdW5kIHRoZW1lIGZvcgorICAgIDs7IFhERyBkZXNrdG9wcyBhbmQgc2hvdWxkIGFs d2F5cyBiZSBwcmVzZW50LgorICAgIDs7IGh0dHA6Ly93d3cuZnJlZWRlc2t0b3Aub3JnL3dpa2kv U3BlY2lmaWNhdGlvbnMvc291bmQtdGhlbWUtc3BlYy8KKyAgICA7OyBXZSBtYWtlIHN1cmUgbGli Y2FuYmVycmEgd2lsbCBmaW5kIGl0LgorICAgIChhcmd1bWVudHMKKyAgICAgYCgjOnBoYXNlcyAK KyAgICAgICAoYWxpc3QtY29ucy1iZWZvcmUKKyAgICAgICAgJ2J1aWxkICdwYXRjaC1kZWZhdWx0 LXNvdW5kcy1kaXJlY3RvcnkKKyAgICAgICAgKGxhbWJkYSogKCM6a2V5IGlucHV0cyAjOmFsbG93 LW90aGVyLWtleXMpCisgICAgICAgICAgKGxldCAoKHNvdW5kcyAoc3RyaW5nLWFwcGVuZAorICAg ICAgICAgICAgICAgICAgICAgICAgIChhc3NvYy1yZWYgaW5wdXRzICJzb3VuZC10aGVtZS1mcmVl ZGVza3RvcCIpCisgICAgICAgICAgICAgICAgICAgICAgICAgIi9zaGFyZSIpKSkKKyAgICAgICAg ICAgIChzdWJzdGl0dXRlKiAic3JjL3NvdW5kLXRoZW1lLXNwZWMuYyIKKyAgICAgICAgICAgICAg KCgicmV0dXJuIFwiL3Vzci9sb2NhbC9zaGFyZTovdXNyL3NoYXJlXCI7IikKKyAgICAgICAgICAg ICAgIChzdHJpbmctYXBwZW5kICJyZXR1cm4gXCIiIHNvdW5kcyAiXCI7XG4iCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiICAgICAgICAgICAgIGVsc2Uge1xuIgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIiAgICAgICAgICAgICAgICBjb25zdCBjaGFyICpzdHAgPSBcIjoi CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzb3VuZHMgIlwiO1xuIgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIiAgICAgICAgICAgICAgICBzaXplX3QgbGVuID0gIHN0cmxl bihzdHApICsgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInN0cmxlbihnKSArIDE7 XG4iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiICAgICAgICAgICAgICAgICIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjaGFyICpnMiA9IChjaGFyKikgbWFsbG9jKGxl bik7XG4iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiICAgICAgICAgICAgICAgIHJl dHVybiAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAic3RyY2F0KHN0cmNweShnMiwg ZyksIHN0cCk7XG4iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiICAgICAgICB9Iikp KSkpCisgICAgICAgICAgJXN0YW5kYXJkLXBoYXNlcykpKQogICAgIChob21lLXBhZ2UgImh0dHA6 Ly8wcG9pbnRlci5kZS9sZW5uYXJ0L3Byb2plY3RzL2xpYmNhbmJlcnJhLyIpCiAgICAgKHN5bm9w c2lzCiAgICAgICJJbXBsZW1lbnRhdGlvbiBvZiB0aGUgWERHIFNvdW5kIFRoZW1lIGFuZCBOYW1l IFNwZWNpZmljYXRpb25zIikKLS0gCjEuOC40Cgo= --001a11c34730b83d7b050c4a65ba--