Re: [PATCH] Add python-statsmodels.

Re: [PATCH] Add python-statsmodels.

[Federico Beffa]

ludo@gnu.org (Ludovic Courtès) writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>> +         (add-after 'unpack 'set-matplotlib-backend-to-agg
>> +          (lambda _
>> +            ;; Set the matplotlib backend to Agg to avoid problems using the
>> +            ;; GTK backend without a display.
>> +            (substitute* (find-files "statsmodels/graphics/tests" "\\.py")
>> +              (("import matplotlib\\.pyplot as plt" line)
>> +               (string-append "import matplotlib;matplotlib.use('Agg');"
>> +                              line)))
>
> This looks good.  Should we eventually change Matplotlib itself to use
> this back-end by default?  What’s at stake exactly?

I don't think so. This back-end is only usable to produce files, it
can't be used for interactive sessions (which is the key appeal of the
numpy/scipy/matplotlib work-flow over C/C++). IMO we should switch to
the TkInter back-end which is part of the standard Python Library. It
was not available in our python when I did package matplotlib.

Regards,
Fede

[PATCH] Add python-statsmodels.

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

Hi Guix,

the attached patch adds python{,2}-statsmodels to statistics.scm.  Note
that this depends on my previous patch adding patsy to the same module.

~~ Ricardo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-statsmodels.patch --]
[-- Type: text/x-patch, Size: 3385 bytes --]

From 33ddc045065722a0bac9b28ad909e838b169d7cb Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Tue, 13 Oct 2015 13:28:58 +0200
Subject: [PATCH 1/2] gnu: Add python-statsmodels.

* gnu/packages/statistics.scm (python-statsmodels, python2-statsmodels):
  New variables.
---
 gnu/packages/statistics.scm | 64 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 1492094..0c0464c 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -989,3 +989,67 @@ building design matrices.")
          ,@(alist-delete "python-numpy"
                          (alist-delete "python-scipy"
                                        (package-propagated-inputs patsy))))))))
+
+(define-public python-statsmodels
+  (package
+    (name "python-statsmodels")
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://pypi.python.org/packages/source/"
+                           "s/statsmodels/statsmodels-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0xn67sqr0cc1lmlhzm71352hrb4hw7g318p5ff5q97pc98vl8kmy"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; tests must be run after installation
+         (delete 'check)
+         (add-after 'unpack 'set-matplotlib-backend-to-agg
+          (lambda _
+            ;; Set the matplotlib backend to Agg to avoid problems using the
+            ;; GTK backend without a display.
+            (substitute* (find-files "statsmodels/graphics/tests" "\\.py")
+              (("import matplotlib\\.pyplot as plt" line)
+               (string-append "import matplotlib;matplotlib.use('Agg');"
+                              line)))
+            #t))
+         (add-after 'install 'check
+          (lambda _
+            (with-directory-excursion "/tmp"
+              (zero? (system* "nosetests"
+                              "--stop"
+                              "-v" "statsmodels"))))))))
+    (propagated-inputs
+     `(("python-numpy" ,python-numpy)
+       ("python-scipy" ,python-scipy)
+       ("python-pandas" ,python-pandas)
+       ("python-patsy" ,python-patsy)
+       ("python-matplotlib" ,python-matplotlib)))
+    (native-inputs
+     `(("python-cython" ,python-cython)
+       ("python-nose" ,python-nose)
+       ("python-sphinx" ,python-sphinx)))
+    (home-page "http://statsmodels.sourceforge.net/")
+    (synopsis "Statistical modeling and econometrics in Python")
+    (description
+     "Statsmodels is a Python package that provides a complement to scipy for
+statistical computations including descriptive statistics and estimation and
+inference for statistical models.")
+    (license license:bsd-3)))
+
+(define-public python2-statsmodels
+  (let ((stats (package-with-python2 python-statsmodels)))
+    (package (inherit stats)
+      (propagated-inputs
+       `(("python2-numpy" ,python2-numpy)
+         ("python2-scipy" ,python2-scipy)
+         ("python2-pandas" ,python2-pandas)
+         ("python2-patsy" ,python2-patsy)
+         ("python2-matplotlib" ,python2-matplotlib)))
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs stats))))))
-- 
2.1.0

Re: [PATCH] Add python-statsmodels.

[Ludovic Courtès]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> the attached patch adds python{,2}-statsmodels to statistics.scm.  Note
> that this depends on my previous patch adding patsy to the same module.

Hmm I lost track of patsy in my inbox.  I’ll check afterwards.

> From 33ddc045065722a0bac9b28ad909e838b169d7cb Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 13 Oct 2015 13:28:58 +0200
> Subject: [PATCH 1/2] gnu: Add python-statsmodels.
>
> * gnu/packages/statistics.scm (python-statsmodels, python2-statsmodels):
>   New variables.

LGTM.

> +         (add-after 'unpack 'set-matplotlib-backend-to-agg
> +          (lambda _
> +            ;; Set the matplotlib backend to Agg to avoid problems using the
> +            ;; GTK backend without a display.
> +            (substitute* (find-files "statsmodels/graphics/tests" "\\.py")
> +              (("import matplotlib\\.pyplot as plt" line)
> +               (string-append "import matplotlib;matplotlib.use('Agg');"
> +                              line)))

This looks good.  Should we eventually change Matplotlib itself to use
this back-end by default?  What’s at stake exactly?

Thanks!

Ludo’.