From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH 2/2] gnu: Add gnome-themes-standard. Date: Tue, 4 Nov 2014 12:15:15 +0100 Message-ID: References: <87sii07x41.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlc4z-0000iK-9w for guix-devel@gnu.org; Tue, 04 Nov 2014 06:15:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xlc4y-0005op-IA for guix-devel@gnu.org; Tue, 04 Nov 2014 06:15:17 -0500 In-Reply-To: <87sii07x41.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel On Mon, Nov 3, 2014 at 11:11 PM, Ludovic Court=C3=A8s wrote: >> +;; The version of this package should be the same as the version of >> +;; gnome-desktop. >> +(define-public gnome-themes-standard >> + (package >> + (name "gnome-themes-standard") >> + (version "3.10.0") > > Please use (version (package-version gnome-desktop)) here, and put the > comment just above it. I thought about this, but did not do it because, if the version changes, then you also need to change the hash. So, if someone changes gnome-desktop without bothering about gnome-themes-standard, then the latter would break. By keeping a separate string the package would still build, but maybe with a slight odd look. WDYT? Regards, Fede