unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Beffa <beffa@ieee.org>
To: Mark H Weaver <mhw@netris.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] profiles: Generate GHC's package database cache.
Date: Sun, 5 Apr 2015 22:33:27 +0200	[thread overview]
Message-ID: <CAKrPhPM2jUDfJocih0y77R7UuuDGuiNz9-PC2fd+fjZ7W_sBhA@mail.gmail.com> (raw)
In-Reply-To: <87h9su4934.fsf@netris.org>

On Sun, Apr 5, 2015 at 10:24 PM, Mark H Weaver <mhw@netris.org> wrote:
>>
>>   ;; Don't depend on GHC when there's nothing to do.
>>   (if (any (cut string-prefix? "ghc" <>)
>>            (map manifest-entry-name (manifest-entries manifest)))
>>       (gexp->derivation "ghc-package-cache" build
>>                         #:modules '((guix build utils))
>>                         #:local-build? #t)
>>       (gexp->derivation "ghc-package-cache" #~(mkdir #$output))))
>
> Sure, this would be fine, although I wonder if we could replace the
> 'string-prefix?' with 'string=?'.  If so, the conditional could be

I used 'string-prefix?' to catch any GHC library (that we are
prefixing with 'ghc-...'). However, to compile such a library we need
GHC, so I think that 'string=?' should do.

> changed to:
>
>   (if (member "ghc" (map manifest-entry-name (manifest-entries manifest)))
>       ...)
>
> What do you think?

Thanks, I will update the patch.
Regards,
Fede

  reply	other threads:[~2015-04-05 20:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 21:10 [PATCH] profiles: Generate GHC's package database cache Federico Beffa
2015-04-05  5:21 ` Mark H Weaver
2015-04-05  8:16   ` Federico Beffa
2015-04-05 20:24     ` Mark H Weaver
2015-04-05 20:33       ` Federico Beffa [this message]
2015-04-06  8:18         ` Federico Beffa
2015-04-06  8:24           ` Mark H Weaver
2015-04-06  8:27             ` Federico Beffa
2015-04-06 19:00               ` Ludovic Courtès
2015-04-10 12:30                 ` Alexandre Héaumé
2015-04-05 20:06 ` Ludovic Courtès
2015-04-05 20:27   ` Federico Beffa
2015-04-15 21:28     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKrPhPM2jUDfJocih0y77R7UuuDGuiNz9-PC2fd+fjZ7W_sBhA@mail.gmail.com \
    --to=beffa@ieee.org \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).