Thanks!

That patch looks fam= iliar :D Looking forward to it.

John

On Sun, Dec 2, 2018 at 1:= 59 PM Ludovic Court=C3=A8s <ludo@gnu.org= > wrote:

Hello,

Bj=C3=B6rn H=C3=B6fling <bjoern.hoefling@bjoernhoefling.de> skribis:<= br>
> And I stumbled upon that problem too. Ludovic explained me on IRC: The=
> problem is the metadata directory ".hg": It contains metadat= a that is
> not fixed. For normal hg-repositories, it will be stripped away, but > not recursively for those with sub-repos.
>
> I have a patch that works. I just wasn't sure if it goes to master= or
> to staging, as it could affect the java-packages as well.

Such a patch can go to =E2=80=98master=E2=80=99: it won=E2=80=99t trigger a= ny rebuild because,
by definition, the content hash of an =E2=80=98origin=E2=80=99 is known in = advance
(these are =E2=80=9Cfixed-output derivations.=E2=80=9D)

However, we should audit current uses of =E2=80=98hg-fetch=E2=80=99 with re= cursive
sub-repos because there hashes are most likely wrong already.

> I'm attaching what I have here, will prepare an official patch ton= ight
> or tomorrow.

Awesome.=C2=A0 FWIW this patch already LGTM.=C2=A0 :-)

Thanks,
Ludo=E2=80=99.

--000000000000ae3ebc057c0e5703-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= Subject: Re: hg-fetch with subrepos Date: Mon, 3 Dec 2018 13:03:28 +0100 Message-ID: <20181203130328.52e52e4e@alma-ubu> References: <72DC8AB8-2987-4EEB-BB69-4FCEF0B1D496@asu.edu> <20181202115355.51c943b5@alma-ubu> <87mupoowrn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/aj8eXUG.m1VidqX5nrP80Y."; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTmww-0008If-Kg for guix-devel@gnu.org; Mon, 03 Dec 2018 07:03:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTmws-0007jL-CI for guix-devel@gnu.org; Mon, 03 Dec 2018 07:03:42 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Soo Cc: guix-devel@gnu.org --Sig_/aj8eXUG.m1VidqX5nrP80Y. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 2 Dec 2018 18:38:35 +0000 John Soo wrote: > Thanks! >=20 > That patch looks familiar :D Looking forward to it. >=20 > John >=20 > On Sun, Dec 2, 2018 at 1:59 PM Ludovic Court=C3=A8s wrote: >=20 > > Hello, > > > > Bj=C3=B6rn H=C3=B6fling skribis: > > =20 > > > And I stumbled upon that problem too. Ludovic explained me on > > > IRC: The problem is the metadata directory ".hg": It contains > > > metadata that is not fixed. For normal hg-repositories, it will > > > be stripped away, but not recursively for those with sub-repos. > > > > > > I have a patch that works. I just wasn't sure if it goes to > > > master or to staging, as it could affect the java-packages as > > > well. =20 > > > > Such a patch can go to =E2=80=98master=E2=80=99: it won=E2=80=99t trigg= er any rebuild > > because, by definition, the content hash of an =E2=80=98origin=E2=80=99= is known in > > advance (these are =E2=80=9Cfixed-output derivations.=E2=80=9D) > > > > However, we should audit current uses of =E2=80=98hg-fetch=E2=80=99 wit= h recursive > > sub-repos because there hashes are most likely wrong already. > > =20 > > > I'm attaching what I have here, will prepare an official patch > > > tonight or tomorrow. =20 > > > > Awesome. FWIW this patch already LGTM. :-) > > > > Thanks, > > Ludo=E2=80=99. > > =20 Thanks John and Ludo for your reviews, pushed to master as: b8ca5b3146f94785c4e54ade1f64dc783a9b1a85 Bj=C3=B6rn --Sig_/aj8eXUG.m1VidqX5nrP80Y. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlwFG5AACgkQvyhstlk+X/2f5QCeJNBg1DZ20YEiKtjyRodj87qo FGkAn0nq5k5Qa8bQcm6YUIfXeI7AIfaE =bYte -----END PGP SIGNATURE----- --Sig_/aj8eXUG.m1VidqX5nrP80Y.--