From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Soo Subject: Re: hg-fetch with subrepos Date: Sun, 2 Dec 2018 18:38:35 +0000 Message-ID: References: <72DC8AB8-2987-4EEB-BB69-4FCEF0B1D496@asu.edu> <20181202115355.51c943b5@alma-ubu> <87mupoowrn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ae3ebc057c0e5703" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTWds-00054N-QG for guix-devel@gnu.org; Sun, 02 Dec 2018 13:38:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTWdp-0000E6-3s for guix-devel@gnu.org; Sun, 02 Dec 2018 13:38:54 -0500 Received: from mail-vs1-xe2d.google.com ([2607:f8b0:4864:20::e2d]:44323) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gTWdk-0000Bc-DY for guix-devel@gnu.org; Sun, 02 Dec 2018 13:38:48 -0500 Received: by mail-vs1-xe2d.google.com with SMTP id g68so6206025vsd.11 for ; Sun, 02 Dec 2018 10:38:46 -0800 (PST) In-Reply-To: <87mupoowrn.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ludo@gnu.org Cc: guix-devel@gnu.org --000000000000ae3ebc057c0e5703 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks! That patch looks familiar :D Looking forward to it. John On Sun, Dec 2, 2018 at 1:59 PM Ludovic Court=C3=A8s wrote: > Hello, > > Bj=C3=B6rn H=C3=B6fling skribis: > > > And I stumbled upon that problem too. Ludovic explained me on IRC: The > > problem is the metadata directory ".hg": It contains metadata that is > > not fixed. For normal hg-repositories, it will be stripped away, but > > not recursively for those with sub-repos. > > > > I have a patch that works. I just wasn't sure if it goes to master or > > to staging, as it could affect the java-packages as well. > > Such a patch can go to =E2=80=98master=E2=80=99: it won=E2=80=99t trigger= any rebuild because, > by definition, the content hash of an =E2=80=98origin=E2=80=99 is known i= n advance > (these are =E2=80=9Cfixed-output derivations.=E2=80=9D) > > However, we should audit current uses of =E2=80=98hg-fetch=E2=80=99 with = recursive > sub-repos because there hashes are most likely wrong already. > > > I'm attaching what I have here, will prepare an official patch tonight > > or tomorrow. > > Awesome. FWIW this patch already LGTM. :-) > > Thanks, > Ludo=E2=80=99. > --000000000000ae3ebc057c0e5703 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks!

That patch looks fam= iliar :D Looking forward to it.

John

On Sun, Dec 2, 2018 at 1:= 59 PM Ludovic Court=C3=A8s <ludo@gnu.org= > wrote:
Hello,

Bj=C3=B6rn H=C3=B6fling <bjoern.hoefling@bjoernhoefling.de> skribis:<= br>
> And I stumbled upon that problem too. Ludovic explained me on IRC: The=
> problem is the metadata directory ".hg": It contains metadat= a that is
> not fixed. For normal hg-repositories, it will be stripped away, but > not recursively for those with sub-repos.
>
> I have a patch that works. I just wasn't sure if it goes to master= or
> to staging, as it could affect the java-packages as well.

Such a patch can go to =E2=80=98master=E2=80=99: it won=E2=80=99t trigger a= ny rebuild because,
by definition, the content hash of an =E2=80=98origin=E2=80=99 is known in = advance
(these are =E2=80=9Cfixed-output derivations.=E2=80=9D)

However, we should audit current uses of =E2=80=98hg-fetch=E2=80=99 with re= cursive
sub-repos because there hashes are most likely wrong already.

> I'm attaching what I have here, will prepare an official patch ton= ight
> or tomorrow.

Awesome.=C2=A0 FWIW this patch already LGTM.=C2=A0 :-)

Thanks,
Ludo=E2=80=99.
--000000000000ae3ebc057c0e5703--