unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Soo <jsoo1@asu.edu>
To: ludo@gnu.org
Cc: guix-devel@gnu.org
Subject: Re: hg-fetch with subrepos
Date: Sun, 2 Dec 2018 18:38:35 +0000	[thread overview]
Message-ID: <CAKf5CqXtEAUc=EtWNRLy6BpVBp4tAmxouPS0rzHQQGw1EY8KMA@mail.gmail.com> (raw)
In-Reply-To: <87mupoowrn.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

Thanks!

That patch looks familiar :D Looking forward to it.

John

On Sun, Dec 2, 2018 at 1:59 PM Ludovic Courtès <ludo@gnu.org> wrote:

> Hello,
>
> Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:
>
> > And I stumbled upon that problem too. Ludovic explained me on IRC: The
> > problem is the metadata directory ".hg": It contains metadata that is
> > not fixed. For normal hg-repositories, it will be stripped away, but
> > not recursively for those with sub-repos.
> >
> > I have a patch that works. I just wasn't sure if it goes to master or
> > to staging, as it could affect the java-packages as well.
>
> Such a patch can go to ‘master’: it won’t trigger any rebuild because,
> by definition, the content hash of an ‘origin’ is known in advance
> (these are “fixed-output derivations.”)
>
> However, we should audit current uses of ‘hg-fetch’ with recursive
> sub-repos because there hashes are most likely wrong already.
>
> > I'm attaching what I have here, will prepare an official patch tonight
> > or tomorrow.
>
> Awesome.  FWIW this patch already LGTM.  :-)
>
> Thanks,
> Ludo’.
>

[-- Attachment #2: Type: text/html, Size: 1634 bytes --]

  reply	other threads:[~2018-12-02 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-01 19:10 hg-fetch with subrepos John Soo
2018-12-02 10:53 ` Björn Höfling
2018-12-02 13:58   ` Ludovic Courtès
2018-12-02 18:38     ` John Soo [this message]
2018-12-03 12:03       ` Björn Höfling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKf5CqXtEAUc=EtWNRLy6BpVBp4tAmxouPS0rzHQQGw1EY8KMA@mail.gmail.com' \
    --to=jsoo1@asu.edu \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).