From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Soo <jsoo1@asu.edu>
Subject: Re: rust-build-system: Unvendor *-sys libraries in phase?
Date: Mon, 27 Jan 2020 14:44:13 +0000
Message-ID: <CAKf5CqX2i_J3MvCroJqCt=hETuMx9-t3R8T6r9KeJq7fn2sfsw@mail.gmail.com>
References: <20200125184959.GM1603@E5400>
 <BE519F52-C1B9-4257-92FB-92D61CD5BD02@asu.edu>
 <20200125193615.GO1603@E5400>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:38164)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <jsoo1@asu.edu>) id 1iw5cp-0006AP-DO
 for guix-devel@gnu.org; Mon, 27 Jan 2020 09:44:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <jsoo1@asu.edu>) id 1iw5co-0005qH-07
 for guix-devel@gnu.org; Mon, 27 Jan 2020 09:44:26 -0500
Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]:36508)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <jsoo1@asu.edu>) id 1iw5cn-0005pU-L4
 for guix-devel@gnu.org; Mon, 27 Jan 2020 09:44:25 -0500
Received: by mail-vk1-xa32.google.com with SMTP id i4so2696763vkc.3
 for <guix-devel@gnu.org>; Mon, 27 Jan 2020 06:44:25 -0800 (PST)
In-Reply-To: <20200125193615.GO1603@E5400>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: Guix-devel <guix-devel@gnu.org>

Hi Efraim,

> I didn't mean to actually fix it, but it seems that just eliminating
> directories is enough to make it work.
>
> I've attached a simple diff against cargo-build-system and rust-libz-sys
> and rust-libgit2-sys which removes the bundled source from both crates
> and builds rust-libgit2-sys without complaints.

This looks good. Can the phases doing the same thing in the arguments
of libgit, etc. be removed too?