From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Mungai Subject: Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix Date: Thu, 26 May 2016 23:44:35 +0300 Message-ID: References: <87r3copogv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=94eb2c053b64aa4b840533c4dbe1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6293-0003cH-OR for guix-devel@gnu.org; Thu, 26 May 2016 16:44:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6291-0007nT-DA for guix-devel@gnu.org; Thu, 26 May 2016 16:44:40 -0400 In-Reply-To: <87r3copogv.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org --94eb2c053b64aa4b840533c4dbe1 Content-Type: text/plain; charset=UTF-8 See corrected patch, as attached. On 26 May 2016 at 23:13, Roel Janssen wrote: > Hello Dennis, > > Welcome and thank you for the patch. > > Dennis Mungai writes: > >> +(define-public llvm-3.8 >> + (package (inherit llvm) >> + (version "3.8.0") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "http://llvm.org/releases/" >> + version "/llvm-" version ".src.tar.xz")) >> + (sha256 >> + (base32 >> + "0ikfq0gxac8xpvxj23l4hk8f12ydx48fljgrz1gl9xp0ks704nsm")))) >> + (native-inputs >> + `(("python" ,python-wrapper) >> + ("perl" ,perl) >> + ("libffi" ,libffi) >> + ("zlib" ,zlib))) > > One space between the string and the unquote is enough. > >> + (arguments >> + `(#:configure-flags '("-DCMAKE_SKIP_BUILD_RPATH=FALSE" >> + "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE" >> + "-DLLVM_ENABLE_PIC=ON" >> + ;"-DLLVM_ENABLE_RTTI=ON" >> + "-DLLVM_ENABLE_WERROR=OFF" >> + ;;"-DLLVM_REQUIRES_RTTI=ON" > > Could you remove the options you commented out? > >> + ))))) > > These should be positioned directly after "-DLLVM_ENABLE_WERROR=OFF". > >> + >> +(define-public clang-runtime-3.8 >> + (clang-runtime-from-llvm >> + llvm-3.8 >> + "1c2nkp9563873ffz22qmhc0wakgj428pch8rmhym8agjamz3ily8")) >> + >> +(define-public clang-3.8 >> + (clang-from-llvm llvm-3.8 clang-runtime-3.8 >> + "1ybcac8hlr9vl3wg8s4v6cp0c0qgqnwprsv85lihbkq3vqv94504")) >> -- >> 2.7.4 > > Thank you, > Roel Janssen --94eb2c053b64aa4b840533c4dbe1 Content-Type: text/x-patch; charset=UTF-8; name="add-llvm-3.8.patch" Content-Disposition: attachment; filename="add-llvm-3.8.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ioorpq4i0 RnJvbSAzODY0M2FjZjUwNzQ5MjEyYTQ0NTVkMTVhMTcyOTAwMmQ2ZGZhMDRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBicmFpbmlhcmM3IDxkbW5nYWllQGdtYWlsLmNvbT4KRGF0ZTog VGh1LCAyNiBNYXkgMjAxNiAyMjozOTowNSArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBMTFZN IDMuOCB0byBHTlUgR3VpeAoKLS0tCiBnbnUvcGFja2FnZXMvbGx2bS5zY20gfCAzOSArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzOSBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2xsdm0uc2NtIGIvZ251L3BhY2th Z2VzL2xsdm0uc2NtCmluZGV4IDNiZjAxOWYuLmU5OTVmZjIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNr YWdlcy9sbHZtLnNjbQorKysgYi9nbnUvcGFja2FnZXMvbGx2bS5zY20KQEAgLTIsNiArMiw5IEBA CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTQgRXJpYyBCYXZpZXIgPGJhdmllckBtZW1iZXIuZnNmLm9y Zz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNSBNYXJrIEggV2VhdmVyIDxtaHdAbmV0cmlzLm9yZz4K IDs7OyBDb3B5cmlnaHQgwqkgMjAxNSBMdWRvdmljIENvdXJ0w6hzIDxsdWRvQGdudS5vcmc+Cis7 OzsgQ29weXJpZ2h0IMKpIDIwMTYgRGVubmlzIE11bmdhaSA8ZG1uZ2FpZUBnbWFpbC5jb20+Cis7 OzsgQ29weXJpZ2h0IMKpIDIwMTYgUGpvdHIgUHJpbnMgPHBqb3RyLnB1YmxpYzEyQHRoZWJpcmQu bmw+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMTYgUm9lbCBKYW5zc2VuIDxyb2VsQGdudS5vcmc+CiA7 OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtMjEsNiArMjQs OCBAQAogKGRlZmluZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBsbHZtKQogICAjOnVzZS1tb2R1bGUg KGd1aXggcGFja2FnZXMpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBsaWNlbnNlcykKKyAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMgY29tcHJlc3Npb24pCisgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIGxpYmZmaSkKICAgIzp1c2UtbW9kdWxlIChndWl4IGRvd25sb2FkKQogICAjOnVzZS1t b2R1bGUgKGd1aXggdXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gZ251 KQpAQCAtMjAxLDMgKzIwNiwzNyBAQCBjb2RlIGFuYWx5c2lzIHRvb2xzLiIpCiAoZGVmaW5lLXB1 YmxpYyBjbGFuZy0zLjUKICAgKGNsYW5nLWZyb20tbGx2bSBsbHZtLTMuNSBjbGFuZy1ydW50aW1l LTMuNQogICAgICAgICAgICAgICAgICAgICIxMnl2M2p3ZGpjYmtyeDd6am04d2g0anJ2YjU5djhm ZHc0bW5tejN6YzFqYjAwcDlrMDd3IikpCisgICAgICAgICAgICAgICAgICAgCisoZGVmaW5lLXB1 YmxpYyBsbHZtLTMuOAorICAocGFja2FnZSAoaW5oZXJpdCBsbHZtKQorICAgICh2ZXJzaW9uICIz LjguMCIpCisgICAgKHNvdXJjZQorICAgICAob3JpZ2luCisgICAgICAgKG1ldGhvZCB1cmwtZmV0 Y2gpCisgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAiaHR0cDovL2xsdm0ub3JnL3JlbGVhc2Vz LyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi9sbHZtLSIgdmVyc2lvbiAi LnNyYy50YXIueHoiKSkKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIKKyAgICAgICAg ICIwaWtmcTBneGFjOHhwdnhqMjNsNGhrOGYxMnlkeDQ4ZmxqZ3J6MWdsOXhwMGtzNzA0bnNtIikp KSkKKyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgicHl0aG9uIiAscHl0aG9uLXdyYXBwZXIp CisgICAgICAgKCJwZXJsIiAscGVybCkKKyAgICAgICAoImxpYmZmaSIgLGxpYmZmaSkKKyAgICAg ICAoInpsaWIiICx6bGliKSkpCisgICAgKGFyZ3VtZW50cworICAgICBgKCM6Y29uZmlndXJlLWZs YWdzICcoIi1EQ01BS0VfU0tJUF9CVUlMRF9SUEFUSD1GQUxTRSIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICItRENNQUtFX0JVSUxEX1dJVEhfSU5TVEFMTF9SUEFUSD1GQUxTRSIKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICItRExMVk1fRU5BQkxFX1BJQz1PTiIKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICItRExMVk1fRU5BQkxFX1dFUlJPUj1PRkYiKSkpKSkKKworKGRlZmlu ZS1wdWJsaWMgY2xhbmctcnVudGltZS0zLjgKKyAgKGNsYW5nLXJ1bnRpbWUtZnJvbS1sbHZtCisg ICBsbHZtLTMuOAorICAgIjFjMm5rcDk1NjM4NzNmZnoyMnFtaGMwd2FrZ2o0MjhwY2g4cm1oeW04 YWdqYW16M2lseTgiKSkKKworKGRlZmluZS1wdWJsaWMgY2xhbmctMy44CisgIChjbGFuZy1mcm9t LWxsdm0gbGx2bS0zLjggY2xhbmctcnVudGltZS0zLjgKKyAgICAgICAgICAgICAgICAgICAiMXli Y2FjOGhscjl2bDN3ZzhzNHY2Y3AwYzBxZ3Fud3Byc3Y4NWxpaGJrcTN2cXY5NDUwNCIpKQotLSAK Mi43LjQKCg== --94eb2c053b64aa4b840533c4dbe1--