unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dennis Mungai <dmngaie@gmail.com>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org,
	Guix-devel
	<guix-devel-bounces+ericbavier=openmailbox.org@gnu.org>
Subject: Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix
Date: Wed, 6 Jul 2016 00:20:47 +0300	[thread overview]
Message-ID: <CAKKYfmGyZfO3kCM5iVkezJqzL+YhWQZuU3cRzCm+0f19X74c9Q@mail.gmail.com> (raw)
In-Reply-To: <87eg77izg8.fsf@gnu.org>

Roel, you may push.

Also, I prefer the name Dennis Mungai.

:-)

On 5 July 2016 at 23:48, Roel Janssen <roel@gnu.org> wrote:
> Hello Dennis,
>
> Thanks for your work on LLVM-3.8.  I see a couple of things:
> - We try to keep lines within 80 columns.
> - libffi and zlib should be inputs instead of native-inputs.
> - zlib is both a license and a package, so the licenses should be
> prefixed.
>
> I created a new patch for you addressing these issues, if you and others
> agree, I can push this one for you.  I verified that the package builds
> and that the programs can be run.
>
> Could you please also let me know whether you want to use the name
> 'brainiarc7' in the commit history, or that you prefer 'Dennis Mungai'.
>
> Thanks again!
>
> Kind regards,
> Roel Janssen
>
> >From 451d93eaaab6166e38e33f0556fe40f83afefc5c Mon Sep 17 00:00:00 2001
> From: brainiarc7 <dmngaie@gmail.com>
> Date: Tue, 5 Jul 2016 22:42:24 +0200
> Subject: [PATCH] gnu: Add LLVM 3.8.
>
> * gnu/packages/llvm.scm (llvm-3.8): New variable.
> * gnu/packages/llvm.scm (clang-runtime-3.8): New variable.
> ---
>  gnu/packages/llvm.scm | 47 +++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 43 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> index 3bf019f..911a5ea 100644
> --- a/gnu/packages/llvm.scm
> +++ b/gnu/packages/llvm.scm
> @@ -2,6 +2,9 @@
>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>  ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2016 Dennis Mungai <dmngaie@gmail.com>
> +;;; Copyright © 2016 Pjotr Prins <pjotr.public12@thebird.nl>
> +;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -20,7 +23,9 @@
>
>  (define-module (gnu packages llvm)
>    #:use-module (guix packages)
> -  #:use-module (guix licenses)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (gnu packages compression)
> +  #:use-module (gnu packages libffi)
>    #:use-module (guix download)
>    #:use-module (guix utils)
>    #:use-module (guix build-system gnu)
> @@ -60,7 +65,7 @@ languages.  It currently supports compilation of C and C++ programs, using
>  front-ends derived from GCC 4.0.1.  A new front-end for the C family of
>  languages is in development.  The compiler infrastructure includes mirror sets
>  of programming tools as well as libraries with equivalent functionality.")
> -    (license ncsa)))
> +    (license license:ncsa)))
>
>  (define (clang-runtime-from-llvm llvm hash)
>    (package
> @@ -87,7 +92,7 @@ of programming tools as well as libraries with equivalent functionality.")
>  functions for C and C++ programs.  It also provides header files that allow C
>  and C++ source code to interface with the \"sanitization\" passes of the clang
>  compiler.  In LLVM this library is called \"compiler-rt\".")
> -    (license ncsa)
> +    (license license:ncsa)
>
>      ;; <http://compiler-rt.llvm.org/> doesn't list MIPS as supported.
>      (supported-systems (delete "mips64el-linux" %supported-systems))))
> @@ -170,7 +175,7 @@ compiler.  In LLVM this library is called \"compiler-rt\".")
>  Objective-C++ programming languages.  It uses LLVM as its back end.  The Clang
>  project includes the Clang front end, the Clang static analyzer, and several
>  code analysis tools.")
> -    (license ncsa)))
> +    (license license:ncsa)))
>
>  (define-public clang-runtime
>    (clang-runtime-from-llvm
> @@ -201,3 +206,37 @@ code analysis tools.")
>  (define-public clang-3.5
>    (clang-from-llvm llvm-3.5 clang-runtime-3.5
>                     "12yv3jwdjcbkrx7zjm8wh4jrvb59v8fdw4mnmz3zc1jb00p9k07w"))
> +
> +(define-public llvm-3.8
> +  (package (inherit llvm)
> +    (version "3.8.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://llvm.org/releases/"
> +                                  version "/llvm-" version ".src.tar.xz"))
> +       (sha256
> +        (base32
> +         "0ikfq0gxac8xpvxj23l4hk8f12ydx48fljgrz1gl9xp0ks704nsm"))))
> +    (inputs
> +     `(("libffi" ,libffi)
> +       ("zlib" ,zlib)))
> +    (native-inputs
> +     `(("python" ,python-wrapper)
> +       ("perl" ,perl)))
> +    (arguments
> +     `(#:configure-flags '("-DCMAKE_SKIP_BUILD_RPATH=FALSE"
> +                           ;; Using the "Release" build type we reduce the
> +                           ;; disk space and compile time footprint
> +                           ;; considerably.
> +                           "-DCMAKE_BUILD_TYPE=Release"
> +                           ;; This option was set on the previous LLVM build,
> +                           ;; so for consistency, use it here too.
> +                           "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE"
> +                           "-DLLVM_ENABLE_PIC=ON"
> +                           ;; Some non-crucial compiler warnings occur.  Treat
> +                           ;; them as warnings instead of errors.
> +                           "-DLLVM_ENABLE_WERROR=OFF")))))
> +
> +(define-public clang-runtime-3.8
> +  (clang-runtime-from-llvm llvm-3.8
> +   "1c2nkp9563873ffz22qmhc0wakgj428pch8rmhym8agjamz3ily8"))
> --
> 2.9.0

  reply	other threads:[~2016-07-05 21:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 19:45 [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix Dennis Mungai
2016-05-26 20:13 ` Roel Janssen
2016-05-26 20:44   ` Dennis Mungai
2016-05-27 14:09     ` Eric Bavier
2016-05-27 15:07       ` Dennis Mungai
2016-05-28  9:22       ` Roel Janssen
2016-05-28 15:30       ` Ludovic Courtès
2016-05-30 22:39         ` Dennis Mungai
2016-06-10 15:42           ` Ludovic Courtès
2016-06-10 16:38         ` Pjotr Prins
2016-06-12 10:17           ` Dennis Mungai
2016-06-12 16:30             ` Ludovic Courtès
2016-06-30 18:15               ` Dennis Mungai
2016-06-30 20:44                 ` Dennis Mungai
2016-07-05 20:48                   ` Roel Janssen
2016-07-05 21:20                     ` Dennis Mungai [this message]
2016-07-05 21:43                       ` Roel Janssen
2016-07-06  4:55                     ` Ricardo Wurmus
2016-07-06 11:54                       ` Efraim Flashner
2016-07-06 18:08                         ` Eric Bavier
2016-07-07  5:06                           ` [PATCH 1/5] gnu: llvm: Update to 3.5.2 ericbavier
2016-07-07  5:06                             ` [PATCH 2/5] gnu: llvm: Add "license:" prefix ericbavier
2016-07-07  5:06                             ` [PATCH 3/5] gnu: llvm: Add libffi and zlib inputs ericbavier
2016-07-07  5:06                             ` [PATCH 4/5] gnu: llvm: Update to 3.7.1 ericbavier
2016-07-07  5:06                             ` [PATCH 5/5] gnu: llvm: Update to 3.8.0 ericbavier
2016-07-11  8:28                             ` [PATCH 1/5] gnu: llvm: Update to 3.5.2 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKKYfmGyZfO3kCM5iVkezJqzL+YhWQZuU3cRzCm+0f19X74c9Q@mail.gmail.com \
    --to=dmngaie@gmail.com \
    --cc=guix-devel-bounces+ericbavier=openmailbox.org@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=roel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).