From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: Add sdparm. Date: Tue, 2 Feb 2016 17:30:07 +0100 Message-ID: References: <1454396674-24793-1-git-send-email-tobias.geerinckx.rice@gmail.com> <1454396674-24793-2-git-send-email-tobias.geerinckx.rice@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQdqr-0006OP-Ce for guix-devel@gnu.org; Tue, 02 Feb 2016 11:30:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQdqq-0001Hi-2u for guix-devel@gnu.org; Tue, 02 Feb 2016 11:30:49 -0500 Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]:33963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQdqp-0001He-QY for guix-devel@gnu.org; Tue, 02 Feb 2016 11:30:47 -0500 Received: by mail-ob0-x235.google.com with SMTP id wb13so121308462obb.1 for ; Tue, 02 Feb 2016 08:30:47 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org On 2 February 2016 at 11:36, Ricardo Wurmus wrote: > > tobias.geerinckx.rice@gmail.com writes: > >> From: Tobias Geerinckx-Rice >> >> * gnu/packages/disk.scm (sdparm): New variable. >> --- >> gnu/packages/disk.scm | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) > > This patch looks very good! Thank you! > >> + (description "Sdparm reads and modifies SCSI device parameters. >> +These devices can be SCSI disks, in which case @command{sdparm}'s role = is >> +similar to its namesake: the Linux @command{hdparm} utility originally >> +designed for ATA disks. However, @command{sdparm} can be used to acces= s >> +parameters on any device that uses a SCSI command set. Such devices >> +include CD/DVD drives (irrespective of transport), SCSI and ATAPI tape >> +drives, and SCSI enclosures. A small set of commands associated with >> +starting and stopping the media, loading and unloading removable media >> +and some other housekeeping functions can also be sent with this utilit= y.") > > I would remove =E2=80=9CLinux=E2=80=9D from the description as neither = =E2=80=9Csdparm=E2=80=9D nor > =E2=80=9Chdparm=E2=80=9D seem to have anything to do with the kernel. This caught my suspicion as well, but then hdparm turned out to be in linux.scm and I dwelt no further on the matter. Go ahead! > > =E2=80=9C[...] functions can [...] be sent=E2=80=9D sounds odd to me. It= probably is > meant to be understood as =E2=80=9Ccommands associated with [...] houseke= eping > functions=E2=80=9D, but that=E2=80=99s not how I parsed it at first. May= be it would be > clearer to reorder the sentence as =E2=80=9CThis utility can also send co= mmands > associated with [this, that, and] some other housekeeping functions=E2=80= =9D. > > If you=E2=80=99re okay with these changes I=E2=80=99ll push it after thes= e slight > modifications. Both are certainly improvements. Thank you for your help! > Thanks again and welcome! I'm going to have to use Emacs, aren't I... > ~~ Ricardo T G-R