From mboxrd@z Thu Jan 1 00:00:00 1970 From: Axel Subject: Re: zsh and fish missed in /etc/shells? Date: Wed, 11 Mar 2015 02:49:23 +0300 Message-ID: References: <87oao2r1fq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVTuI-0000hV-1A for guix-devel@gnu.org; Tue, 10 Mar 2015 19:49:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVTuG-0004S5-HO for guix-devel@gnu.org; Tue, 10 Mar 2015 19:49:49 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel I found tcsh in packages list and maybe missed some other shells. Seems like we need more general solution than patch proposed by me. Also maybe merge all shells to a new common package "gnu shells" instead of separate packages? 2015-03-11 1:30 GMT+03:00 Axel : > Thank you for explanation, I installed these packages system wide and > got symbolic links. I prepared the patch for gnu/system.scm but I > unsure about the way I used to check packages availability > (find-packages-by-name). I see only the problem when one user > installed the package and other don't =E2=80=94 the new shell will be add= ed to > the list anyway. But I not found how to check that package was > installed system wide. > > And generally should we check that shells really installed or just > unconditionally add paths to /etc/shells? I will modify patch then. > > > > 2015-03-09 11:59 GMT+03:00 Ludovic Court=C3=A8s : >> Axel skribis: >> >>> Could we append /etc/shells with `zsh` or `fish` paths after these >>> shells installed in the system? >> >> Sure! Would you like to submit a patch? This is in gnu/system.scm. >> >>> And I think these shells should be linked to >>> /run/current-system/profile/bin/ as `bash` does. >> >> To do that, all you need to do is to add them to the =E2=80=98packages= =E2=80=99 field of >> the =E2=80=98operating-system=E2=80=99 declaration: >> >> (operating-system >> ;; ... >> (packages (cons* fish zsh %base-packages))) >> >> Thanks, >> Ludo=E2=80=99. > > > > -- > =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=80 =D0=93=D1=80=D0=B0= =D1=84=D0=BE=D0=B2 --=20 =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=80 =D0=93=D1=80=D0=B0= =D1=84=D0=BE=D0=B2