From: "Thompson, David" <dthompson2@worcester.edu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] environment: container: Do not remount network files as read-only.
Date: Sat, 26 Mar 2016 15:23:06 -0400 [thread overview]
Message-ID: <CAJ=RwfbfMwDzHH6gkud9pLePKNBded=XGRxxm=iDL0vrd=9OrA@mail.gmail.com> (raw)
In-Reply-To: <87r3exyt97.fsf@gnu.org>
On Sat, Mar 26, 2016 at 2:43 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> "Thompson, David" <dthompson2@worcester.edu> skribis:
>
>> On Fri, Mar 18, 2016 at 4:51 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>>> "Thompson, David" <dthompson2@worcester.edu> skribis:
>>>
>>>> I noticed that 'guix environment --container --network' didn't work on
>>>> an Ubuntu machine I was on, and the culprit was remounting things like
>>>> /etc/resolv.conf read-only after the initial bind mount.
>>>
>>> [...]
>>>
>>>> (file-system-mapping
>>>> (source file)
>>>> (target file)
>>>> - (writable? #f))))
>>>> + ;; An unpriviliged user might not
>>>> + ;; be able to remount
>>>> + ;; /etc/resolv.conf as read-only,
>>>> + ;; so we say that it is writable
>>>> + ;; here, even though in practice
>>>> + ;; it is not.
>>>> + (writable? #t))))
>>>> %network-configuration-files)
>>>
>>> Not sure I understand: why would bind-mounting /etc/resolv.conf
>>> read-only fail?
>>
>> I haven't figured out the exact reason yet, but here's a strace
>> snippet as proof:
>>
>> [pid 11334] mount("/etc/resolv.conf",
>> "/tmp/guix-directory.Rc4nc6//etc/resolv.conf", 0x23da000,
>> MS_RDONLY|MS_BIND, NULL) = 0
>> [pid 11334] mount("/etc/resolv.conf",
>> "/tmp/guix-directory.Rc4nc6//etc/resolv.conf", 0x23e4080,
>> MS_RDONLY|MS_REMOUNT|MS_BIND, NULL) = -1 EPERM (Operation not
>> permitted)
>>
>> Another Ubuntu user was able to reproduce this as well.
>
> Looking at the resolvconf man page that Drew mentioned, it seems that
> /etc/resolv.conf is a symlink when resolvconf is in used, right?
>
> If yes, does this make a difference:
/etc/resolv.conf is a symlink, but the patch doesn't work.
> It may be that the result after this is that you get /etc/resolv.conf in
> the container, but it’s a dangling symlink. But isn’t it the case
> already with the patch you propose?
No, /etc/resolv.conf appears as a regular file inside the container,
even though it's a symlink outside. The mount namespace does the
right thing and I can read the contents of it from within the
container. No dangling symlink! :D
I tried using --expose with a symlink as an attempt to replicate the
problem with another file, but things went fine! I'm confused.
What's the correct patch here now? :)
- Dave
next prev parent reply other threads:[~2016-03-26 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 18:32 [PATCH] environment: container: Do not remount network files as read-only Thompson, David
2016-03-18 20:51 ` Ludovic Courtès
2016-03-26 14:06 ` Thompson, David
2016-03-26 16:29 ` Drew C
2016-03-26 16:49 ` Thompson, David
2016-03-26 16:59 ` Drew C
2016-03-26 18:43 ` Ludovic Courtès
2016-03-26 18:54 ` Drew C
2016-03-26 19:23 ` Thompson, David [this message]
2016-03-27 17:43 ` Ludovic Courtès
2016-03-28 0:32 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfbfMwDzHH6gkud9pLePKNBded=XGRxxm=iDL0vrd=9OrA@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).