From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH 4/4] environment: Add '--debug' flag. Date: Tue, 19 Jul 2016 13:14:04 -0400 Message-ID: References: <20160719164916.6597-1-david@craven.ch> <20160719164916.6597-5-david@craven.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYau-0001ib-7J for guix-devel@gnu.org; Tue, 19 Jul 2016 13:14:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPYas-0007Td-5z for guix-devel@gnu.org; Tue, 19 Jul 2016 13:14:07 -0400 Received: from mail-vk0-x22e.google.com ([2607:f8b0:400c:c05::22e]:35919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYar-0007TY-Vf for guix-devel@gnu.org; Tue, 19 Jul 2016 13:14:06 -0400 Received: by mail-vk0-x22e.google.com with SMTP id g1so21315333vkb.3 for ; Tue, 19 Jul 2016 10:14:05 -0700 (PDT) In-Reply-To: <20160719164916.6597-5-david@craven.ch> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel Hi David, On Tue, Jul 19, 2016 at 12:49 PM, David Craven wrote: > * guix/scripts/environment.scm: Add '--debug' flag to add common debugging > packages (file, gdb, strace, valgrind) to environment. Thanks for the patch and trying to make 'guix environment' more friendly, but I don't really like this particular change for a few reasons: - The name "--debug" is misleading. When I saw the patch subject line, I thought it was a way to get 'guix environment' to print some verbose output for the sake of debugging the generated environments. As a user, I wouldn't expect --debug to affect the set of packages in the environment. - The debugging tools that a developer would want vary depending on the project. I don't use GDB or valgrind to debug my Guile programs, for example. - It tightly couples 'guix environment' to a particular, opinionated set of packages. What if the user wants to use a different variant of gdb? - Tools like strace are Linux-specific but we have plans to support additional kernels like the Hurd. I don't perceive a usability problem in this area, but that doesn't mean there isn't one. Could you explain your motivations behind this patch? Perhaps there's an alternative thing we could do, but in general I don't envision 'guix environment' having a deep knowledge of the available packages and having opinions about which packages users should choose. - Dave