From: "Thompson, David" <dthompson2@worcester.edu>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add ruby-libxml and bioruby.
Date: Tue, 15 Sep 2015 10:39:56 -0400 [thread overview]
Message-ID: <CAJ=RwfbOP6Fuy4Km7mXVEub3W1HRVr2dBUQo0krr2pQfeiqyMQ@mail.gmail.com> (raw)
In-Reply-To: <20150915131935.GA2778@thebird.nl>
On Tue, Sep 15, 2015 at 9:19 AM, Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> On Tue, Sep 15, 2015 at 08:58:28AM -0400, Thompson, David wrote:
>> > + (native-inputs `(("ruby-libxml" ,ruby-libxml)))
>>
>> This should be a propagated input.
>
> oops. I can be such a noob.
No worries. :)
>> > + (inputs
>> > + `(("coreutils" ,coreutils) ; required for /bin/echo in tests
>>
>> Coreutils is an implict input to the Ruby build system.
>
> well, echo is not found by which, so coreutils is missing.
That is odd. Coreutils is most definitely there. I added this to a
build phase of another Ruby package and rebuilt it:
(pk 'ECHO (which "echo"))
And the file name for echo was indeed displayed.
>> Usually gems with native extensions just redundantly build themselves
>> in the source directory before running tests, which I guess is not the
>> case here.
>>
>> It looks like you need to at least add ruby-rake-compiler to
>> native-inputs and run 'rake compile' before running the tests.
>
> I tried that.
Ah, damn. Well let's not worry about it too much, then.
>> I tried to do this outside the build container from a git checkout
>> and several tests failed. Give it a shot in the build recipe and
>> see how it goes. If the problems are very difficult to solve, we
>> can leave the tests disabled with a note about the failures and
>> problems to solve.
>
> No dice.
>
>> Unfortunately, it seems there's no way to avoid compiling native
>> extensions twice when we do run tests since it needs to be compiled in
>> the source tree for tests, and then again when running 'gem install'.
>> The Ruby way of building things leaves much to be desired.
>
> Aye. Tests assume an already installed extension. The good news is
> that bioruby tests include ruby-libxml tests. So, at least, the
> integration works.
OK, cool. That sounds good enough, then.
One more thing that I forgot: Use the 'modify-phases' syntax instead
of 'alist-cons-before' for the build phases.
Thanks!
- Dave
next prev parent reply other threads:[~2015-09-15 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 12:15 [PATCH] gnu: Add ruby-libxml and bioruby Pjotr Prins
2015-09-15 12:58 ` Thompson, David
2015-09-15 13:19 ` Pjotr Prins
2015-09-15 14:39 ` Thompson, David [this message]
2015-09-17 5:24 ` Pjotr Prins
2015-09-17 5:37 ` [PATCH] gnu: Add ruby-libxml Pjotr Prins
2015-09-19 16:34 ` Thompson, David
2015-09-17 6:17 ` [PATCH] gnu: Add ruby-libxml and bioruby Pjotr Prins
2015-09-19 16:42 ` Thompson, David
2015-09-15 13:44 ` Pjotr Prins
-- strict thread matches above, loose matches on Subject: below --
2015-09-15 12:16 Pjotr Prins
2015-09-15 12:24 ` Pjotr Prins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfbOP6Fuy4Km7mXVEub3W1HRVr2dBUQo0krr2pQfeiqyMQ@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=pjotr.public12@thebird.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).