From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH 01/10] gnu: Add emacs-smex. Date: Thu, 2 Jun 2016 09:33:35 -0400 Message-ID: References: <20160601140538.20311-1-dthompson2@worcester.edu> <87vb1slz61.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Skj-0005eZ-Rv for guix-devel@gnu.org; Thu, 02 Jun 2016 09:33:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8Ski-0004Me-DJ for guix-devel@gnu.org; Thu, 02 Jun 2016 09:33:37 -0400 Received: from mail-yw0-x241.google.com ([2607:f8b0:4002:c05::241]:35269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Ski-0004MY-8n for guix-devel@gnu.org; Thu, 02 Jun 2016 09:33:36 -0400 Received: by mail-yw0-x241.google.com with SMTP id n16so6844049ywd.2 for ; Thu, 02 Jun 2016 06:33:36 -0700 (PDT) In-Reply-To: <87vb1slz61.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel , David Thompson On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost wrote: > David Thompson (2016-06-01 17:05 +0300) wrote: > >> From: David Thompson >> >> * gnu/packages/emacs.scm (emacs-smex): New variable. >> --- >> gnu/packages/emacs.scm | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> >> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >> index b7c0a1f..71f2f8b 100644 >> --- a/gnu/packages/emacs.scm >> +++ b/gnu/packages/emacs.scm >> @@ -10,6 +10,7 @@ >> ;;; Copyright =C2=A9 2015, 2016 Christopher Allan Webber >> ;;; Copyright =C2=A9 2016 humanitiesNerd >> ;;; Copyright =C2=A9 2016 Efraim Flashner >> +;;; Copyright =C2=A9 2016 David Thompson >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.") >> Emacs default configuration in uncontroversial ways that nearly everyon= e can >> agree upon.") >> (license license:gpl3+))) >> + >> +(define-public emacs-smex >> + (package >> + (name "emacs-smex") >> + (version "3.0") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://raw.githubusercontent.com" >> + "/nonsequitur/smex/" version "/smex.e= l")) > > Hm, I see in some packages you use these "githubusercontent" URLs > instead of as > we usually do for github. IIUC you did it to avoid extra files > (".gitignore", etc.) in the final package directory, right? If so, I > think it is not needed, I would still use a link to a tagged source code > archive. Moreover I think it's a problem of emacs-build-system that > these uninteresting files are not removed. > > Overall, I don't mind against "githubusercontent", I was just wondering. > Actually, I think you found a good way how to pick the needed files to > make several packages from a single repo (as you did for > "ido-ubiquitous" and "ido-completing-read+"). Yes, I did this to avoid all sorts of unnecessary files making into the store, as well as making it more closely mimic the single elisp files that were released on MELPA or whatever. These URLs are stable, so I thought it had a good clever/useful hack ratio. :) - Dave