From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] system: container: Update to new service API. Date: Thu, 29 Oct 2015 20:58:27 -0400 Message-ID: References: <87611txiw7.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87k2q8v42g.fsf@gnu.org> <87y4el49np.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=94eb2c093a32eafa8e052347ecfa Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zry1V-0001FH-Rr for guix-devel@gnu.org; Thu, 29 Oct 2015 20:58:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zry1U-0002oY-QO for guix-devel@gnu.org; Thu, 29 Oct 2015 20:58:29 -0400 Received: from mail-yk0-x234.google.com ([2607:f8b0:4002:c07::234]:36745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zry1U-0002oF-Iy for guix-devel@gnu.org; Thu, 29 Oct 2015 20:58:28 -0400 Received: by ykba4 with SMTP id a4so61011416ykb.3 for ; Thu, 29 Oct 2015 17:58:28 -0700 (PDT) In-Reply-To: <87y4el49np.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel --94eb2c093a32eafa8e052347ecfa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Oct 29, 2015 at 6:00 PM, Ludovic Court=C3=A8s wrote: > "Thompson, David" skribis: > >> On Tue, Oct 27, 2015 at 9:22 AM, Ludovic Court=C3=A8s wro= te: >>> Sorry, I meant to preserve #:container? behavior but I forgot this bit. >>> >>> I believe the attached patch provides an Even Greater Way to address th= e >>> problem, namely by making the modprobe/firmware thing an optional >>> service. >>> >>> Could you try and report back? I tried it in a VM and there=E2=80=99s = no >>> regression. >> >> It works great, thanks! > > Applied! Thanks! Here's the new patch. - Dave --94eb2c093a32eafa8e052347ecfa Content-Type: text/x-diff; charset=US-ASCII; name="0001-system-container-Adjust-to-changes-in-gexps.patch" Content-Disposition: attachment; filename="0001-system-container-Adjust-to-changes-in-gexps.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igcybdc80 RnJvbSA3NTAxMzE1NTAzNTRhMjU1NDFhM2FkY2RkOTgzZjQwNTNiYjg2Y2M5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBUaHUsIDI5IE9jdCAyMDE1IDAwOjE1OjM2IC0wNDAwClN1YmplY3Q6IFtQQVRD SF0gc3lzdGVtOiBjb250YWluZXI6IEFkanVzdCB0byBjaGFuZ2VzIGluIGdleHBzLgoKKiBnbnUv c3lzdGVtL2xpbnV4LWNvbnRhaW5lci5zY20gKHN5c3RlbS1jb250YWluZXIpOiAnZXRjJyBpcyBu byBsb25nZXIKICBhIG1vbmFkaWMgdmFsdWUsIGFuZCB0aGUgcmVzdWx0IG9mICdmaWxlLXVuaW9u JyBtdXN0IGJlIGxvd2VyZWQuCi0tLQogZ251L3N5c3RlbS9saW51eC1jb250YWluZXIuc2NtIHwg MTQgKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDYgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3N5c3RlbS9saW51eC1jb250YWluZXIuc2NtIGIv Z251L3N5c3RlbS9saW51eC1jb250YWluZXIuc2NtCmluZGV4IGZkZjc0NjAuLmFiZTgxNmYgMTAw NjQ0Ci0tLSBhL2dudS9zeXN0ZW0vbGludXgtY29udGFpbmVyLnNjbQorKysgYi9nbnUvc3lzdGVt L2xpbnV4LWNvbnRhaW5lci5zY20KQEAgLTI1LDYgKzI1LDcgQEAKICAgIzp1c2UtbW9kdWxlIChn dWl4IGRlcml2YXRpb25zKQogICAjOnVzZS1tb2R1bGUgKGd1aXggbW9uYWRzKQogICAjOnVzZS1t b2R1bGUgKGdudSBidWlsZCBsaW51eC1jb250YWluZXIpCisgICM6dXNlLW1vZHVsZSAoZ251IHNl cnZpY2VzKQogICAjOnVzZS1tb2R1bGUgKGdudSBzeXN0ZW0pCiAgICM6dXNlLW1vZHVsZSAoZ251 IHN5c3RlbSBmaWxlLXN5c3RlbXMpCiAgICM6ZXhwb3J0IChtYXBwaW5nLT5maWxlLXN5c3RlbQpA QCAtNTAsMTQgKzUxLDE1IEBACiAgICJSZXR1cm4gYSBkZXJpdmF0aW9uIHRoYXQgYnVpbGRzIE9T IGFzIGEgTGludXggY29udGFpbmVyLiIKICAgKG1sZXQqICVzdG9yZS1tb25hZAogICAgICAgKChw cm9maWxlIChvcGVyYXRpbmctc3lzdGVtLXByb2ZpbGUgb3MpKQotICAgICAgIChldGMgICAgIChv cGVyYXRpbmctc3lzdGVtLWV0Yy1kaXJlY3Rvcnkgb3MpKQorICAgICAgIChldGMgIC0+IChvcGVy YXRpbmctc3lzdGVtLWV0Yy1kaXJlY3Rvcnkgb3MpKQogICAgICAgIChib290ICAgIChvcGVyYXRp bmctc3lzdGVtLWJvb3Qtc2NyaXB0IG9zICM6Y29udGFpbmVyPyAjdCkpCiAgICAgICAgKGxvY2Fs ZSAgKG9wZXJhdGluZy1zeXN0ZW0tbG9jYWxlLWRpcmVjdG9yeSBvcykpKQotICAgIChmaWxlLXVu aW9uICJzeXN0ZW0tY29udGFpbmVyIgotICAgICAgICAgICAgICAgIGAoKCJib290IiAsI34jJGJv b3QpCi0gICAgICAgICAgICAgICAgICAoInByb2ZpbGUiICwjfiMkcHJvZmlsZSkKLSAgICAgICAg ICAgICAgICAgICgibG9jYWxlIiAsI34jJGxvY2FsZSkKLSAgICAgICAgICAgICAgICAgICgiZXRj IiAsI34jJGV0YykpKSkpCisgICAgKGxvd2VyLW9iamVjdAorICAgICAoZmlsZS11bmlvbiAic3lz dGVtLWNvbnRhaW5lciIKKyAgICAgICAgICAgICAgICAgYCgoImJvb3QiICwjfiMkYm9vdCkKKyAg ICAgICAgICAgICAgICAgICAoInByb2ZpbGUiICwjfiMkcHJvZmlsZSkKKyAgICAgICAgICAgICAg ICAgICAoImxvY2FsZSIgLCN+IyRsb2NhbGUpCisgICAgICAgICAgICAgICAgICAgKCJldGMiICwj fiMkZXRjKSkpKSkpCiAKIChkZWZpbmUgKGNvbnRhaW5lcml6ZWQtb3BlcmF0aW5nLXN5c3RlbSBv cyBtYXBwaW5ncykKICAgIlJldHVybiBhbiBvcGVyYXRpbmcgc3lzdGVtIGJhc2VkIG9uIE9TIGZv ciB1c2UgaW4gYSBMaW51eCBjb250YWluZXIKLS0gCjIuNS4wCgo= --94eb2c093a32eafa8e052347ecfa--