From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Thompson, David" <dthompson2@worcester.edu>
Subject: Re: [PATCH] gnu: services: Add redis-service
Date: Fri, 13 Jan 2017 09:22:01 -0500
Message-ID: <CAJ=RwfaeuPCE3NYA8rJePhHcGk9L_W8SKjDxAkPyg+v0z1xNvQ@mail.gmail.com>
References: <20170110072401.6756-1-mail@cbaines.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1cS2k4-0003ru-Vq
	for guix-devel@gnu.org; Fri, 13 Jan 2017 09:22:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1cS2jz-0007qM-0u
	for guix-devel@gnu.org; Fri, 13 Jan 2017 09:22:08 -0500
Received: from mail-vk0-x242.google.com ([2607:f8b0:400c:c05::242]:33725)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <dthompson2@worcester.edu>)
	id 1cS2jy-0007qE-Py
	for guix-devel@gnu.org; Fri, 13 Jan 2017 09:22:02 -0500
Received: by mail-vk0-x242.google.com with SMTP id j12so3860449vkd.0
	for <guix-devel@gnu.org>; Fri, 13 Jan 2017 06:22:02 -0800 (PST)
In-Reply-To: <20170110072401.6756-1-mail@cbaines.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel <guix-devel@gnu.org>

Hello,

On Tue, Jan 10, 2017 at 2:24 AM, Christopher Baines <mail@cbaines.net> wrote:
>
> diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm
> index d88c839f7..b6bdd6080 100644
> --- a/gnu/services/databases.scm
> +++ b/gnu/services/databases.scm
> @@ -35,7 +35,11 @@
>              mysql-service
>              mysql-service-type
>              mysql-configuration
> -            mysql-configuration?))
> +            mysql-configuration?
> +
> +            redis-configuration
> +            redis-configuration?
> +            redis-service-type))
>
>  ;;; Commentary:
>  ;;;
> @@ -287,3 +291,78 @@ database server.
>  The optional @var{config} argument specifies the configuration for
>  @command{mysqld}, which should be a @code{<mysql-configuration>} object."
>    (service mysql-service-type config))
> +
> +
> +;;;
> +;;; Redis
> +;;;
> +
> +(define-record-type* <redis-configuration>
> +  redis-configuration make-redis-configuration
> +  redis-configuration?
> +  (redis             redis-configuration-redis ;<package>
> +                     (default redis))
> +  (bind              redis-configuration-bind
> +                     (default "127.0.0.1"))
> +  (port              redis-configuration-port
> +                     (default 6379))
> +  (working-directory redis-configuration-working-directory
> +                     (default "/var/lib/redis"))
> +  (config-file       redis-configuration-config-file
> +                     (default #f)))

I'm seeing a trend where people write services with configuration
types that don't cover nearly the amount of configuration options to
make the service useful.  MySQL, and now this Redis server, are
examples of this.  There are many more configuration options in Redis
than this service exposes.

What do we do?

- Dave