unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] guix environment: return the return value of the executed command.
@ 2015-07-01 21:03 Cyril Roelandt
  2015-07-01 21:45 ` Thompson, David
  0 siblings, 1 reply; 2+ messages in thread
From: Cyril Roelandt @ 2015-07-01 21:03 UTC (permalink / raw)
  To: guix-devel

* gnu/scripts/environment.scm (guix-environment): return the return value of
  (system command).
---
 guix/scripts/environment.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
index 007fde1..95474e7 100644
--- a/guix/scripts/environment.scm
+++ b/guix/scripts/environment.scm
@@ -254,4 +254,4 @@ packages."
                (show-search-paths inputs drvs pure?))
               (else
                (create-environment inputs drvs pure?)
-               (system command)))))))
+               (exit (status:exit-val (system command)))))))))
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] guix environment: return the return value of the executed command.
  2015-07-01 21:03 [PATCH] guix environment: return the return value of the executed command Cyril Roelandt
@ 2015-07-01 21:45 ` Thompson, David
  0 siblings, 0 replies; 2+ messages in thread
From: Thompson, David @ 2015-07-01 21:45 UTC (permalink / raw)
  To: Cyril Roelandt; +Cc: guix-devel

For the patch title, change to: "scripts: environment: Return the exit
status of the command."

On Wed, Jul 1, 2015 at 5:03 PM, Cyril Roelandt <tipecaml@gmail.com> wrote:
> * gnu/scripts/environment.scm (guix-environment): return the return value of
>   (system command).

Rather:

    * guix/scripts/environment.scm (guix-environment): Return the exit
status of the command.

> ---
>  guix/scripts/environment.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
> index 007fde1..95474e7 100644
> --- a/guix/scripts/environment.scm
> +++ b/guix/scripts/environment.scm
> @@ -254,4 +254,4 @@ packages."
>                 (show-search-paths inputs drvs pure?))
>                (else
>                 (create-environment inputs drvs pure?)
> -               (system command)))))))
> +               (exit (status:exit-val (system command)))))))))
> --
> 1.8.4.rc3

Please push after adjusting the commit log.

Thanks!

- Dave

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-01 21:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 21:03 [PATCH] guix environment: return the return value of the executed command Cyril Roelandt
2015-07-01 21:45 ` Thompson, David

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).