From: "Thompson, David" <dthompson2@worcester.edu>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] build: file-systems: Allow for bind mounting regular files.
Date: Sun, 2 Aug 2015 08:51:46 -0400 [thread overview]
Message-ID: <CAJ=Rwfa5fZOP2eC-NBv01J_NmbK5UFX7m7F=LK6JdjeL4F4eBA@mail.gmail.com> (raw)
In-Reply-To: <CAJ=RwfbgKQ=3yetHsEpGFdSaHhAazYozQ3Mv5fR=VYS0uvObGA@mail.gmail.com>
On Sun, Aug 2, 2015 at 8:43 AM, Thompson, David
<dthompson2@worcester.edu> wrote:
> On Sun, Aug 2, 2015 at 8:10 AM, Alex Kost <alezost@gmail.com> wrote:
>> David Thompson (2015-08-01 22:17 +0300) wrote:
>>
>>> diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
>>> index c58d23c..f0d6f70 100644
>>> --- a/gnu/build/file-systems.scm
>>> +++ b/gnu/build/file-systems.scm
>>> @@ -305,6 +305,10 @@ the following:
>>> fsck code device)
>>> (start-repl)))))
>>>
>>> +(define (regular-file? file-name)
>>> + "Return #t if FILE-NAME is a regular file."
>>> + (eq? (stat:type (stat file-name)) 'regular))
>>
>> There are similar procedures in (guix build utils): 'directory-exists?',
>> 'executable-file?' and 'symbolic-link?'. So I think it is better to put
>> 'regular-file?' there. WDYT?
>
> Sure, that makes sense. Done.
Ah, of course, I forgot about something: This patch triggers a
rebuild of *everything* now! I guess it should be applied to
core-updates. Or, the first patch I submitted can be applied to
master, and then a patch that moves 'regular-file?' to (guix build
utils) can be applied to core-updates later.
Thoughts?
- Dave
next prev parent reply other threads:[~2015-08-02 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 19:17 [PATCH] build: file-systems: Allow for bind mounting regular files David Thompson
2015-08-02 12:10 ` Alex Kost
2015-08-02 12:43 ` Thompson, David
2015-08-02 12:51 ` Thompson, David [this message]
2015-08-02 13:31 ` Andreas Enge
2015-08-03 12:47 ` Alex Kost
2015-08-06 12:22 ` Thompson, David
2015-08-07 7:06 ` Alex Kost
2015-08-18 15:52 ` Ludovic Courtès
2015-08-18 16:43 ` Thompson, David
2015-08-08 18:28 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=Rwfa5fZOP2eC-NBv01J_NmbK5UFX7m7F=LK6JdjeL4F4eBA@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).