[PATCH 1/2] gnu: Update pumpa source URL.

[PATCH 1/2] gnu: Update pumpa source URL.

[Claes Wallin (韋嘉誠)]

From: Claes Wallin <claes.wallin@greatsinodevelopment.com>

* pumpio.scn (pumpa): Update gitorious.org URL to branchable.com URL.
---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 4a6375f..26d7b4a 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -34,7 +34,7 @@
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "https://gitorious.org/pumpa/pumpa.git")
+                    (url "git://pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32
-- 
2.4.3

[PATCH 2/2] gnu: Update pumpa to 0.9.1.

[Claes Wallin (韋嘉誠)]

From: Claes Wallin <claes.wallin@greatsinodevelopment.com>

---
 gnu/packages/pumpio.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 26d7b4a..22c631e 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -30,7 +30,7 @@
 (define-public pumpa
   (package
     (name "pumpa")
-    (version "0.9")
+    (version "0.9.1")
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
@@ -38,7 +38,7 @@
                     (commit (string-append "v" version))))
               (sha256
                (base32
-                "0v55xq17wnc9mvpmrm5r3rjrsg9npnjv1lznbz8ppk77ba8pwimy"))))
+                "14s0m46yqph8bs5rjpmiq42f020j9l3mygan2zj93z6qzypwd07f"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases (alist-replace
-- 
2.4.3

Re: [PATCH 2/2] gnu: Update pumpa to 0.9.1.

[Mathieu Lirzin]

Hi,

I think the URL change and the package update commits can be squashed
with a commit message like this:

gnu: pumpa: Update to 0.9.1.

* gnu/packages/pumpio.scm (pumpa): Update to 0.9.1.  Change URL.

--
Mathieu Lirzin

[PATCH 1/2] gnu: Update pumpa source URL.

[Claes Wallin (韋嘉誠)]

From: Claes Wallin <claes.wallin@greatsinodevelopment.com>

* gnu/packages/pumpio.scm (pumpa): Update gitorious.org URL to branchable.com URL.
---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 4a6375f..26d7b4a 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -34,7 +34,7 @@
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "https://gitorious.org/pumpa/pumpa.git")
+                    (url "git://pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32
-- 
2.4.3

[PATCH 2/2] gnu: Update pumpa to 0.9.1.

[Claes Wallin (韋嘉誠)]

From: Claes Wallin <claes.wallin@greatsinodevelopment.com>

* gnu/packages/pumpio.scm (pumpa): Update version to 0.9.1.
---
 gnu/packages/pumpio.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 26d7b4a..22c631e 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -30,7 +30,7 @@
 (define-public pumpa
   (package
     (name "pumpa")
-    (version "0.9")
+    (version "0.9.1")
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
@@ -38,7 +38,7 @@
                     (commit (string-append "v" version))))
               (sha256
                (base32
-                "0v55xq17wnc9mvpmrm5r3rjrsg9npnjv1lznbz8ppk77ba8pwimy"))))
+                "14s0m46yqph8bs5rjpmiq42f020j9l3mygan2zj93z6qzypwd07f"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases (alist-replace
-- 
2.4.3

(unknown),

[Claes Wallin (韋嘉誠)]

Ok! Sending the merged patch. Sorry for the patch spam, still figuring out the git-send-mail way of working.

-- 
   /c

[PATCH] gnu: Update pumpa to 0.9.1.

[Claes Wallin (韋嘉誠)]

From: Claes Wallin <claes.wallin@greatsinodevelopment.com>

* gnu/packages/pumpio.scm (pumpa): Update gitorious.org URL to branchable.com URL.
* gnu/packages/pumpio.scm (pumpa): Update version to 0.9.1.
---
 gnu/packages/pumpio.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 4a6375f..22c631e 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -30,15 +30,15 @@
 (define-public pumpa
   (package
     (name "pumpa")
-    (version "0.9")
+    (version "0.9.1")
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "https://gitorious.org/pumpa/pumpa.git")
+                    (url "git://pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32
-                "0v55xq17wnc9mvpmrm5r3rjrsg9npnjv1lznbz8ppk77ba8pwimy"))))
+                "14s0m46yqph8bs5rjpmiq42f020j9l3mygan2zj93z6qzypwd07f"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases (alist-replace
-- 
2.4.3

Re: [PATCH] gnu: Update pumpa to 0.9.1.

[Mathieu Lirzin]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

"Claes Wallin (韋嘉誠)" <gnu@clacke.user.lysator.liu.se> writes:

> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
>
> * gnu/packages/pumpio.scm (pumpa): Update gitorious.org URL to branchable.com URL.
> * gnu/packages/pumpio.scm (pumpa): Update version to 0.9.1.

You can look and search through the ChangeLog file after 'make dist' or
directly throught git logs for commit conventions. Since an update is
very common it's very easy to find something to copy from.

To avoid mistakes with 'git send-mail', it is a good idea to try with
one of your personnal email address before sending to the list.

I've Checked if your patch builds correcty and corrected the commit
message. Tell me if it's ok for you.

--
Mathieu Lirzin


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-pumpa-Update-to-0.9.1.patch --]
[-- Type: text/x-diff, Size: 1328 bytes --]

From 246c0ba5a97941391aa5421a4f3a6cd4841ed6ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claes=20Wallin=20=28=E9=9F=8B=E5=98=89=E8=AA=A0=29?=
 <gnu@clacke.user.lysator.liu.se>
Date: Thu, 9 Jul 2015 00:28:34 +0200
Subject: [PATCH] gnu: pumpa: Update to 0.9.1.

* gnu/packages/pumpio.scm (pumpa): Update to 0.9.1.  Change URL.

Signed-off-by: Mathieu Lirzin <mthl@openmailbox.org>
---
 gnu/packages/pumpio.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 4a6375f..22c631e 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -30,15 +30,15 @@
 (define-public pumpa
   (package
     (name "pumpa")
-    (version "0.9")
+    (version "0.9.1")
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "https://gitorious.org/pumpa/pumpa.git")
+                    (url "git://pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32
-                "0v55xq17wnc9mvpmrm5r3rjrsg9npnjv1lznbz8ppk77ba8pwimy"))))
+                "14s0m46yqph8bs5rjpmiq42f020j9l3mygan2zj93z6qzypwd07f"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases (alist-replace
-- 
2.1.4

Re: [PATCH] gnu: Update pumpa to 0.9.1.

[Claes Wallin (韋嘉誠)]

On Thu, Jul 9, 2015 at 1:54 AM, Mathieu Lirzin <mthl@openmailbox.org> wrote:
> "Claes Wallin (韋嘉誠)" <gnu@clacke.user.lysator.liu.se> writes:
>
>> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
>>
>> * gnu/packages/pumpio.scm (pumpa): Update gitorious.org URL to branchable.com URL.
>> * gnu/packages/pumpio.scm (pumpa): Update version to 0.9.1.
>
> You can look and search through the ChangeLog file after 'make dist' or
> directly throught git logs for commit conventions. Since an update is
> very common it's very easy to find something to copy from.
>
> To avoid mistakes with 'git send-mail', it is a good idea to try with
> one of your personnal email address before sending to the list.

Yes, of course, on both accounts. I will be less impatient next time. :-)

(... aaand I submitted my reply to Mathieu only. As any bad worksman,
I blame my tools.)

> I've Checked if your patch builds correcty and corrected the commit
> message. Tell me if it's ok for you.

Looks great.

-- 
   /c

Re: [PATCH] gnu: Update pumpa to 0.9.1.

[Mathieu Lirzin]

One last thing before pushing. :)

Following the
http://lists.gnu.org/archive/html/guix-devel/2015-07/msg00235.html
discussion, I want to know if the usage of the email address
<gnu@clacke.user.lysator.liu.se> instead of
<claes.wallin@greatsinodevelopment.com> in your patch was intentionnal?

If not, please send an updated patch that uses your usual address.  Else
indicate which address you want to be added to 'AUTHORS'.

--
Mathieu Lirzin

PS: There is no need to use "git send-mail ..." here.  Just attach the
file generated by "git format-patch origin/master" to your answer.

Re: [PATCH] gnu: Update pumpa to 0.9.1.

[Claes Wallin (韋嘉誠)]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Jul 9, 2015 7:49 PM, "Mathieu Lirzin" <mthl@openmailbox.org> wrote:
>
> One last thing before pushing. :)
>
> Following the
> http://lists.gnu.org/archive/html/guix-devel/2015-07/msg00235.html
> discussion, I want to know if the usage of the email address
> <gnu@clacke.user.lysator.liu.se> instead of
> <claes.wallin@greatsinodevelopment.com> in your patch was intentionnal?

Do you mean the opposite? I use gnu@ on the list, but I would like my
patches (and AUTHORS) to use @greatsino. I think that's what I did?

> PS: There is no need to use "git send-mail ..." here.  Just attach the
> file generated by "git format-patch origin/master" to your answer.

The advantage I see with git send-mail is that the patch is readable inline
when reading the list archive and list mail, and in the case of a
multi-step patch it neatly groups patches together ... when you do it right.

[-- Attachment #2: Type: text/html, Size: 1312 bytes --]

Re: [PATCH] gnu: Update pumpa to 0.9.1.

[Thompson, David]

On Fri, Jul 10, 2015 at 4:31 AM, Claes Wallin (韋嘉誠)
<gnu@clacke.user.lysator.liu.se> wrote:
> On Jul 9, 2015 7:49 PM, "Mathieu Lirzin" <mthl@openmailbox.org> wrote:
>>
>> PS: There is no need to use "git send-mail ..." here.  Just attach the
>> file generated by "git format-patch origin/master" to your answer.
>
> The advantage I see with git send-mail is that the patch is readable inline
> when reading the list archive and list mail, and in the case of a multi-step
> patch it neatly groups patches together ... when you do it right.

You don't need git send-email for this, just tell your mail client to
inline the patch attachments.

- Dave

Re: [PATCH] gnu: Update pumpa to 0.9.1.

[Mathieu Lirzin]

Pushed in commit fd83aa000c111f457528deb3a87d0f9e920e5801.

--
Mathieu Lirzin