From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCHES] Upgrade Kodi to 16.0 Date: Sat, 12 Mar 2016 20:02:51 -0500 Message-ID: References: <8760wrip2v.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87pouzfoeg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeuQn-0002sg-QG for guix-devel@gnu.org; Sat, 12 Mar 2016 20:02:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeuQm-0007Hv-In for guix-devel@gnu.org; Sat, 12 Mar 2016 20:02:53 -0500 Received: from mail-yw0-x235.google.com ([2607:f8b0:4002:c05::235]:34303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeuQm-0007HW-EH for guix-devel@gnu.org; Sat, 12 Mar 2016 20:02:52 -0500 Received: by mail-yw0-x235.google.com with SMTP id h129so131076481ywb.1 for ; Sat, 12 Mar 2016 17:02:52 -0800 (PST) In-Reply-To: <87pouzfoeg.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin Cc: guix-devel Hello Mathieu, On Sat, Mar 12, 2016 at 3:10 PM, Mathieu Lirzin wrote: > Hello David, > > David Thompson writes: > >>>From 80f08dde121610dcc832f4e6ecdd11341166580c Mon Sep 17 00:00:00 2001 >> From: David Thompson >> Date: Sat, 12 Mar 2016 12:23:47 -0500 >> Subject: [PATCH 1/3] gnu: Add crossguid. >> >> * gnu/packages/kodi.scm (crossguid): New variable. >> --- > [...] >> +(define-public crossguid >> + (let ((commit "8f399e8bd4252be9952f3dfa8199924cc8487ca4")) >> + (package >> + (name "crossguid") >> + (version (string-append "0.0-1." (string-take commit 7))) >> + ;; There's no official release. Just a Git repository. >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/graeme-hill/crossguid.gi= t") >> + (commit commit))) >> + (sha256 >> + (base32 >> + "1i29y207qqddvaxbn39pk2fbh3gx8zvdprfp35wasj9rw2wjk3s9= ")))) > > You have omitted =E2=80=9C(file-name (string-append name "-" version ".ta= r.gz"))=E2=80=9D. Not in this case because it's a git checkout, not a tarball download. >> + (build-system gnu-build-system) > > Maybe =E2=80=98trivial-build-system=E2=80=99 would be more adapted. WDYT= ? The GNU build system still does plenty of useful things like patching shebangs, validating runpaths, and providing GCC. So, I'd like to keep it. >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + (delete 'configure) ; no configure script >> + ;; There's no build system here, so we have to do it ourselv= es. >> + (replace 'build >> + (lambda _ >> + (and (zero? (system* "g++" "-c" "guid.cpp" "-o" "guid.o" >> + "-std=3Dc++11" "-DGUID_LIBUUID")) >> + (zero? (system* "ar" "rvs" "libcrossguid.a" "guid.o= "))))) >> + (replace 'check >> + (lambda _ >> + (and (zero? (system* "g++" "-c" "test.cpp" "-o" "test.o" >> + "-std=3Dc++11")) >> + (zero? (system* "g++" "-c" "testmain.cpp" "-o" "tes= tmain.o" >> + "-std=3Dc++11")) >> + (zero? (system* "g++" "test.o" "guid.o" "testmain.o= " >> + "-o" "test" "-luuid")) >> + (zero? (system* (string-append (getcwd) "/test"))))= )) >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out"))) >> + (install-file "guid.h" (string-append out "/include")) >> + (install-file "libcrossguid.a" >> + (string-append out "/lib")) >> + #t)))))) >> + (inputs >> + `(("util-linux" ,util-linux))) >> + (synopsis "Lightweight GUID/UUID library") > > What about using =E2=80=9CLightweight universal identifier library=E2=80= =9D to avoid > technical abbreviations? Sure. >> + (description "CrossGuid is a minimal GUID/UUID generator library = for >> +C++.") > > I think using =E2=80=9C@acronym{}=E2=80=9D for GUID and UUID would be app= ropriate. > Could you rephrase the description to describe their usual purpose? I added the "@acronym{}" stuff, but I don't think the description needs expanding. >>>From c7a1e349381a36080fb72a31f32665be157d22fe Mon Sep 17 00:00:00 2001 >> From: David Thompson >> Date: Tue, 1 Mar 2016 10:04:14 -0500 >> Subject: [PATCH 2/3] gnu: Add dcadec. >> >> * gnu/packages/audio.scm (dcadec): New variable. >> --- > [...] >> + >> +(define-public dcadec >> + (package >> + (name "dcadec") >> + (version "0.2.0") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/foo86/dcadec/arch= ive/v" >> + version ".tar.gz")) >> + (sha256 >> + (base32 >> + "0i0dpypgqkhhi4v1fmsp2way6w9kbcix3c7q79pmg39yvrzj17gd")= ))) > > Like previous patch =E2=80=9C(file-name (string-append name "-" version "= .tar.gz"))=E2=80=9D. Oops, thanks for catching this! Fixed. >>>From 11f770f17e1965ce7316a4820a1ad652f1bdc0bf Mon Sep 17 00:00:00 2001 >> From: David Thompson >> Date: Mon, 29 Feb 2016 21:34:00 -0500 >> Subject: [PATCH 3/3] gnu: kodi: Update to 16.0. >> >> * gnu/packages/kodi.scm (kodi): Update to 16.0. > > =E2=80=9C[inputs]: Add crossguid, dcadec, and util-linux.=E2=80=9D Done. If no one has any other comments then I will push soon. Thanks! - Dave