From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] Add aragorn. Date: Tue, 21 Jul 2015 10:01:49 -0400 Message-ID: References: <55AE4599.5040601@uq.edu.au> <55AE4F3A.1050903@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHY7H-0000en-5H for guix-devel@gnu.org; Tue, 21 Jul 2015 10:01:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHY7D-0003OE-6E for guix-devel@gnu.org; Tue, 21 Jul 2015 10:01:55 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:34983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHY7D-0003Nr-00 for guix-devel@gnu.org; Tue, 21 Jul 2015 10:01:51 -0400 Received: by lblf12 with SMTP id f12so116467795lbl.2 for ; Tue, 21 Jul 2015 07:01:49 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: "guix-devel@gnu.org" On Tue, Jul 21, 2015 at 9:57 AM, Ricardo Wurmus wrote: > Something=E2=80=99s wrong with the alignment of the =E2=80=98(replace 'in= stall ...)=E2=80=99. > If there are no objections I can fix the alignment and push without > requesting another version of the patch. > > But I think I better wait for other comments. Looks fine to me, sans the alignment. One additional nitpick is the 'string-append' calls. The newlines should happen *after* the first argument, not before. - Dave