unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 3/4] gnu: Add ruby-timecop.
Date: Sun, 5 Jun 2016 09:56:33 -0400	[thread overview]
Message-ID: <CAJ=RwfZWKGJGr8ZanFLJ7r5so3Cg3Bw0hC-+sx_qGNszbFdH=g@mail.gmail.com> (raw)
In-Reply-To: <1465131653-28176-4-git-send-email-donttrustben@gmail.com>

On Sun, Jun 5, 2016 at 9:00 AM, Ben Woodcroft <donttrustben@gmail.com> wrote:
> * gnu/packages/ruby.scm (ruby-timecop): New variable.
> ---
>  gnu/packages/ruby.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 319971e..71b13e4 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3969,3 +3969,40 @@ comprehensive ORM layer for mapping records to Ruby objects and handling
>  associated records.")
>      (home-page "http://sequel.jeremyevans.net")
>      (license license:expat)))
> +
> +(define-public ruby-timecop
> +  (package
> +    (name "ruby-timecop")
> +    (version "0.8.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "timecop" version))
> +       (sha256
> +        (base32
> +         "0vwbkwqyxhavzvr1820hqwz43ylnfcf6w4x6sag0nghi44sr9kmx"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'set-check-rubylib
> +           (lambda _
> +             (setenv "RUBYLIB" "lib")

Could you add a comment explaining what this is for?

> +             ;; Delete test file which requires activesupport and
> +             ;; (currently broken) tzinfo-data.
> +             (delete-file "test/time_stack_item_test.rb")
> +             #t)))))
> +    (native-inputs
> +     `(("bundler" ,bundler)
> +       ("ruby-minitest-rg" ,ruby-minitest-rg)
> +       ("ruby-mocha" ,ruby-mocha)))
> +    (synopsis "Test mocks for time-dependent functions.")
> +    (description
> +     "This package provides a gem providing \"time travel\" and \"time
> +freezing\" capabilities, making it easier to test time-dependent code.  It
> +provides a unified method to mock @code{Time.now}, @code{Date.today}, and
> +@code{DateTime.now} in a single call.")

Rather: "Timecop provides \"time travel" and ..."

> +    (home-page "https://github.com/travisjeffery/timecop")
> +    (license license:expat)))
> +
> +
> --
> 2.7.4
>
>

- Dave

  reply	other threads:[~2016-06-05 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-05 13:00 [PATCH 0/4]: A few rubygems Ben Woodcroft
2016-06-05 13:00 ` [PATCH 1/4] gnu: Add ruby-tzinfo-data Ben Woodcroft
2016-06-05 13:54   ` Thompson, David
2016-06-05 13:00 ` [PATCH 2/4] gnu: ruby-activesupport: Add 'ruby-tzinfo-data' propagated input Ben Woodcroft
2016-06-06  8:12   ` Ludovic Courtès
2016-06-08 11:44     ` Ben Woodcroft
2016-06-05 13:00 ` [PATCH 3/4] gnu: Add ruby-timecop Ben Woodcroft
2016-06-05 13:56   ` Thompson, David [this message]
2016-06-05 13:00 ` [PATCH 4/4] gnu: Add ruby-concurrent Ben Woodcroft
2016-06-05 14:02   ` Thompson, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfZWKGJGr8ZanFLJ7r5so3Cg3Bw0hC-+sx_qGNszbFdH=g@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=donttrustben@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).