From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] make nginx service extensible Date: Fri, 6 Jan 2017 10:03:15 -0500 Message-ID: References: <20161213215615.5518d4c0@lepiller.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPW34-0006EY-5u for guix-devel@gnu.org; Fri, 06 Jan 2017 10:03:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPW33-00034E-7C for guix-devel@gnu.org; Fri, 06 Jan 2017 10:03:18 -0500 Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:35624) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPW33-00033x-2H for guix-devel@gnu.org; Fri, 06 Jan 2017 10:03:17 -0500 Received: by mail-vk0-x22c.google.com with SMTP id m128so2565369vkb.2 for ; Fri, 06 Jan 2017 07:03:16 -0800 (PST) In-Reply-To: <20161213215615.5518d4c0@lepiller.eu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller Cc: guix-devel Hi Julien, On Tue, Dec 13, 2016 at 3:56 PM, Julien Lepiller wrote: > Hi, > > here are three patches for the nginx service. I finally worked on > them. > > 1. s/vhost/server/ in the web.scm and guix.texi > 2. fix a mistake with the list of names and index. > 3. make the service extensible, change the default options and document > it. > > I hope that's correct now :) Thank you for making these improvements. I wrote the original barebones nginx-service and just never got around to making it extensible. This should make a bunch of people very happy. :) - Dave