unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add MARS shooter.
Date: Sat, 19 Sep 2015 16:33:02 -0400	[thread overview]
Message-ID: <CAJ=RwfYbgZuvubprQwuV4xdXKQGAmWwE-OeE7oWe=P1z8zYSYQ@mail.gmail.com> (raw)
In-Reply-To: <87twqq5g3o.fsf@elephly.net>

On Sat, Sep 19, 2015 at 4:06 PM, Ricardo Wurmus <rekado@elephly.net> wrote:
>
> Thompson, David <dthompson2@worcester.edu> writes:
>
>>> “Content-Type: .gz” is what trips up “guix download”.  What follows
>>> “Content-Type:” should be a mime type and I suppose “.gz” is not a valid
>>> mime type.  Would it make sense for the HTTP client to be a little more
>>> tolerant about this?
>>
>> No, upstream needs to fix their invalid Content-Type header.  We've
>> had this problem a few times, most recently with rubygems.org, and in
>> all cases we've gotten upstream to fix it.  Strict header parsing can
>> seem like an issue at times, but it's really a very good feature that
>> the rest of the world seems to ignore. [0]
>
> I wonder what a correct Content-Type header would look like in this
> case.  I would like to submit a helpful report containing what I got and
> what it should have been.

In this case, application/x-gzip or application/octet-stream would be
appropriate.  Less specifically, the media type needs to match the
syntax as defined by the W3C spec. [0]

> However, this is independent from the patch itself where I’m using a git
> reference.

Ah yes, you are right. :)

- Dave

[0] http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.7

  reply	other threads:[~2015-09-19 20:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 19:25 [PATCH] Add MARS shooter Ricardo Wurmus
2015-09-19  8:25 ` Ricardo Wurmus
2015-09-19 15:44   ` Thompson, David
2015-09-19 20:06     ` Ricardo Wurmus
2015-09-19 20:33       ` Thompson, David [this message]
2015-09-20  7:51         ` Ricardo Wurmus
2015-09-20  9:46           ` Ricardo Wurmus
2015-09-25 22:30     ` Christopher Allan Webber
2015-09-26 13:04       ` Ludovic Courtès
2015-09-19 17:17 ` Eric Bavier
2015-09-20 10:08   ` Ricardo Wurmus
2015-09-20 16:30   ` Version strings for VCS snapshots Ludovic Courtès
2015-09-23  6:13     ` Ricardo Wurmus
2015-09-23 23:35     ` Mark H Weaver
2015-09-24  8:11       ` Andreas Enge
2015-09-24 11:12       ` Ludovic Courtès
2015-09-20 15:49 ` [PATCH] Add MARS shooter Ricardo Wurmus
2015-09-20 20:19   ` Eric Bavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfYbgZuvubprQwuV4xdXKQGAmWwE-OeE7oWe=P1z8zYSYQ@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).