From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] gnu: Add desmume. Date: Mon, 29 Feb 2016 15:54:22 -0500 Message-ID: References: <56D4AA82.2020801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUpk-0004Js-G1 for guix-devel@gnu.org; Mon, 29 Feb 2016 15:54:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaUpj-00026I-Ot for guix-devel@gnu.org; Mon, 29 Feb 2016 15:54:24 -0500 Received: from mail-yw0-x232.google.com ([2607:f8b0:4002:c05::232]:35265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUpj-00026D-Ji for guix-devel@gnu.org; Mon, 29 Feb 2016 15:54:23 -0500 Received: by mail-yw0-x232.google.com with SMTP id g127so132142860ywf.2 for ; Mon, 29 Feb 2016 12:54:23 -0800 (PST) In-Reply-To: <56D4AA82.2020801@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Manolis Ragkousis Cc: guix-devel On Mon, Feb 29, 2016 at 3:30 PM, Manolis Ragkousis wrote: > This patch adds DeSmuMe a Nintendo DS emulator. I am looking forward to > using it with emulation-station :-) > > It's licensed under the GPLv2 and doesn't require any binary firmware > from the DS to run. Thanks for checking out the potential firmware issue. This looks great overall, but could you expand the description a bit and make sure there's a period at the end of the sentence(s)? Thanks, - Dave