unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] 11 little Ruby gems.
Date: Tue, 6 Oct 2015 14:25:18 -0400	[thread overview]
Message-ID: <CAJ=RwfY6hktEF+scmw3+iuGabcj2Q7WjjPWzRz-NZ7zm+jt-hg@mail.gmail.com> (raw)
In-Reply-To: <5613E0C7.1020607@uq.edu.au>

On Tue, Oct 6, 2015 at 10:55 AM, Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:
>
> Stupidly not being aware of this thread I believe I've got ruby-yard
> packaged without disabling tests just now, by packaging rspec-2 (and
> skipping the 2 remaining failing tests that write to /homeless-shelter). I
> think that issue on github might be incorrect (there's no rspec 2.14.3 on
> rubygems only 2.14.1 which seems to work for me). It actually means 4 new
> rspec-2 packages in total, there's no dependency issues beyond rspec I don't
> think. Would you like me to send patches? My suspicion is that there might
> be other packages that rely on rspec-2 out there, but that's just a hunch
> more than anything.

Since you've already got it packaged, then I think we should do that.
The migration from Rspec 2 -> 3 is nontrivial so I won't be surprised
if we run into other gems that use Rspec 2.  Regarding the
/homeless-shelter thing, you should be able to make those tests pass
by creating some directory in the source tree and set HOME to it.

In short, yes, your patches are very welcome.  Thanks!

- Dave

  reply	other threads:[~2015-10-06 18:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  9:12 [PATCH] 11 little Ruby gems Ricardo Wurmus
2015-09-19 12:54 ` Thompson, David
2015-09-19 20:15   ` Ricardo Wurmus
2015-10-06 14:35   ` Ricardo Wurmus
2015-10-06 14:55     ` Ben Woodcroft
2015-10-06 18:25       ` Thompson, David [this message]
2015-10-07  9:08         ` Ben Woodcroft
2015-10-13 14:08           ` Ricardo Wurmus
2015-10-14  2:27             ` Ben Woodcroft
2015-10-30 16:22   ` Ricardo Wurmus
2015-10-31 10:33     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfY6hktEF+scmw3+iuGabcj2Q7WjjPWzRz-NZ7zm+jt-hg@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).