unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Catonano <catonano@gmail.com>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add emacs-clojure-mode
Date: Thu, 19 May 2016 12:20:34 +0200	[thread overview]
Message-ID: <CAJ98PDzNQXtJQ8xiHAQvFxBvWuV10QiR9ox5bZAn6OdcHbq_qg@mail.gmail.com> (raw)
In-Reply-To: <878tz61l7s.fsf@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2076 bytes --]

2016-05-19 10:54 GMT+02:00 Alex Kost <alezost@gmail.com>:

> > Subject: gnu: Add emacs-clojure-mode
>                                       ^
> This is a nitpick of course, but we put a period here...
>
> > * gnu/packages/emacs.scm (emacs-clojure-mode): New variable
>                                                              ^
> ... and here.
>

Do you mean like this ?

Subject: gnu: Add emacs-clojure-mode.

* gnu/packages/emacs.scm (emacs-clojure-mode): New variable.


> > +(define-public emacs-clojure-mode
> > +  (package
> > +    (name "emacs-clojure-mode")
> > +    (version "5.3.0")
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url "https://github.com/clojure-emacs/clojure-mode.git")
> > +             (commit "8ef7127da214cb7fd4b47fc943462f2a8bfb8f85")))
>
> Is there a reason to use 'git-fetch'?  I think a usual 'url-fetch' is
> fine as there is:
> <https://github.com/clojure-emacs/clojure-mode/archive/5.3.0.tar.gz>.
>

No, there's no specific reason. Fixed it.

> +       (file-name (string-append name "-" version "-checkout"))
> > +       (sha256
> > +        (base32
> > +          "1x7nl5wzcah9hnlj5jfd3y5604w60zcqcw1nn6vw335c2vzzissj"))))
> > +    (build-system emacs-build-system)
> > +    (home-page "http://github.com/clojure-emacs/clojure-mode")
> > +    (synopsis "Major mode for Clojure code")
> > +    (description
> > +     "Provides font-lock, indentation, navigation and basic refactoring
> for the
>
> We use full sentences for descriptions, like this: "This emacs package
> provides ..."
>

Fixed


>
> > +Clojure programming language (http://clojure.org).
>
> Since we use texinfo to format descriptions, it is better to write:
>
>   @uref{http://clojure.org, Clojure programming language}
>

Fixed


>
> > +
> > +Using clojure-mode with paredit or smartparens is highly recommended.
>
> I think this description is too verbose.  I would remove all the text
> below.
>

Ok, I cut it.

So, I edited the patch and attached it again.
Would you see if it fits ?
Thanks

[-- Attachment #1.2: Type: text/html, Size: 3931 bytes --]

[-- Attachment #2: 0001-gnu-Add-emacs-clojure-mode.patch --]
[-- Type: text/x-patch, Size: 1436 bytes --]

From 6dc8470baf3493a93da3e3358136e5c9860d4e3a Mon Sep 17 00:00:00 2001
From: humanitiesNerd <catonano@gmail.com>
Date: Wed, 18 May 2016 15:41:47 +0200
Subject: gnu: Add emacs-clojure-mode.

* gnu/packages/emacs.scm (emacs-clojure-mode): New variable.
---
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 32ed722..fb07bc7 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1612,3 +1612,28 @@ It is built on top of the custom theme support in Emacs 24 or later.")
     (license license:gpl3+)))
 
 
+(define-public emacs-clojure-mode
+  (package
+    (name "emacs-clojure-mode")
+    (version "5.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/clojure-emacs/clojure-mode/archive/"
+             version
+             ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+         (base32
+         "0gi8ra3ap5m3mz4qh1yxp2cldn7z9xcxvypznr6rrlc6a9l8s5a6"))))
+    (build-system emacs-build-system)
+    (home-page "http://github.com/clojure-emacs/clojure-mode")
+    (synopsis "Major mode for Clojure code")
+    (description
+     "This Emacs package provides font-lock, indentation,3
+navigation and basic refactoring for the
+@uref{http://clojure.org, Clojure programming language}
+
+Using clojure-mode with paredit or smartparens is highly recommended.")
+    (license license:gpl3+)))


  reply	other threads:[~2016-05-19 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 15:09 [PATCH] gnu: Add emacs-clojure-mode Catonano
2016-05-19  8:54 ` Alex Kost
2016-05-19 10:20   ` Catonano [this message]
2016-05-24  8:51     ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ98PDzNQXtJQ8xiHAQvFxBvWuV10QiR9ox5bZAn6OdcHbq_qg@mail.gmail.com \
    --to=catonano@gmail.com \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).