From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catonano Subject: Re: code review Date: Fri, 8 Dec 2017 14:53:57 +0100 Message-ID: References: <20170912203519.31bb6943@cbaines.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f403045e94fc1dbeb3055fd48421" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNJ6G-0004Ih-6Y for guix-devel@gnu.org; Fri, 08 Dec 2017 08:54:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNJ6F-0004xo-86 for guix-devel@gnu.org; Fri, 08 Dec 2017 08:54:00 -0500 Received: from mail-yw0-x22d.google.com ([2607:f8b0:4002:c05::22d]:38166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNJ6F-0004xX-2Z for guix-devel@gnu.org; Fri, 08 Dec 2017 08:53:59 -0500 Received: by mail-yw0-x22d.google.com with SMTP id x199so4262445ywg.5 for ; Fri, 08 Dec 2017 05:53:58 -0800 (PST) In-Reply-To: <20170912203519.31bb6943@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel --f403045e94fc1dbeb3055fd48421 Content-Type: text/plain; charset="UTF-8" 2017-09-12 21:35 GMT+02:00 Christopher Baines : > On Mon, 11 Sep 2017 22:10:22 +0200 > Catonano wrote: > Hi Chris, thank you for your review. And I apologize for the long delay. I tried to follow some of your suggestions here https://gitlab.com/humanitiesNerd/guix-hacks/blob/trytonservice/gnu/services/trytond.scm I didn't try to implement the abstraction for the postgres connections The postgres service right now uses the operating system user "postgres" in order to connect under the "postgres" role, so avoiding to use a password I did the same with the "tryton" operating system user and the "tryton" role This assumes that the postgres service and thhe Tryton service are rnning on the same server and this could be restrictive in some situations Honestly I wasn't willing to wrap my mind around I just want to have a minimum Tryton service running Postgres commands for connecting safely to a remote postgres server I just want to have a minimum Tryton service running I hope this is ok Anyway, now I should try to write some system tests or these 2 services I wrote Any patch would be welcome ;-) Thanks --f403045e94fc1dbeb3055fd48421 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2017-09-12 21:35 GMT+02:00 Christopher Baines <mail@cbaine= s.net>:
On Mon, 11 Sep 2017 22:= 10:22 +0200
Catonano <catonano@gmail.com&g= t; wrote:


Hi Chris,

<= /div>
thank you for your review. And I apologize for the long delay.

I didn= 9;t try to implement the abstraction for the postgres connections

The postgres service right now uses the operating system user &quo= t;postgres" in order to connect under the "postgres" role, s= o avoiding to use a password

I did the same with the &quo= t;tryton" operating system user and the "tryton" role

This assumes that the postgres service and thhe Tryt= on service are rnning on the same server and this could be restrictive in s= ome situations

Honestly I wasn't willing to wrap my m= ind around
I just want to have a minimum Tryton service running

Postgres commands for connecting safely to a remote postg= res server

I just want to have a minimum Tryton service r= unning

I hope this is ok

Any= way, now I should try to write some system tests or these 2 services I wrot= e
Any patch would be welcome ;-)

Thanks

--f403045e94fc1dbeb3055fd48421--