From: zimoun <zimon.toutoune@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates?
Date: Tue, 16 Mar 2021 19:19:53 +0100 [thread overview]
Message-ID: <CAJ3okZ3VWMGnR3r+A1CpdX9JdgTOUdcyi+XZ781DJZLRgdpA9A@mail.gmail.com> (raw)
In-Reply-To: <YFDxLvQcaiJadhJJ@jasmine.lan>
Hi,
On Tue, 16 Mar 2021 at 18:56, Leo Famulari <leo@famulari.name> wrote:
>
> On Tue, Mar 16, 2021 at 05:34:34PM +0100, zimoun wrote:
> > The question is: should the next release 1.2.1 contain zstd@1.4.9 as
> > graft? Or do we revert the commit and simply fix it on core-updates
> > and wait for the next core-updates cycle. Personally, I am in favor
> > of the latter. WDYT?
>
> The release should not contain any grafts, if we can help it.
>
> On the wip-next-release branch, I've simply updated zstd to 1.4.9:
I guess that it will not build for i686. Does it?
If not, the patch attached to the previous email tweaks the offending
test; as the original author of zstd has suggested:
<https://github.com/facebook/zstd/issues/2528#issuecomment-794704882>
(Thanks to the other Leo for opening the issue.)
Well, I am confused. If the update of zstd from 1.4.4 to 1.4.9 does
not imply a huge rebuild, why is it a graft? And not a simple update?
Cheers,
simon
next prev parent reply other threads:[~2021-03-16 18:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 5:09 GNU Guix (pull?) on i686 broke after zstd grafting Léo Le Bouter
2021-03-06 5:30 ` Léo Le Bouter
2021-03-10 10:37 ` Ludovic Courtès
2021-03-10 10:43 ` Léo Le Bouter
2021-03-11 2:11 ` Léo Le Bouter
2021-03-11 9:37 ` zimoun
2021-03-11 9:40 ` Léo Le Bouter
2021-03-11 9:58 ` zimoun
2021-03-11 10:05 ` Léo Le Bouter
2021-03-16 16:34 ` Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates? zimoun
2021-03-16 17:06 ` Léo Le Bouter
2021-03-16 17:48 ` Leo Famulari
2021-03-16 18:03 ` Léo Le Bouter
2021-03-16 17:59 ` zimoun
2021-03-16 17:55 ` Leo Famulari
2021-03-16 18:08 ` Léo Le Bouter
2021-03-16 18:46 ` zimoun
2021-03-16 18:50 ` Léo Le Bouter
2021-03-16 19:04 ` zimoun
2021-03-16 18:19 ` zimoun [this message]
2021-03-16 18:26 ` Léo Le Bouter
2021-03-16 19:18 ` Leo Famulari
2021-03-16 19:25 ` zimoun
2021-03-16 19:29 ` Leo Famulari
2021-03-16 21:46 ` Security-czar needed? WAS: " Bengt Richter
2021-03-16 22:03 ` Leo Famulari
2021-03-17 6:24 ` Léo Le Bouter
2021-03-17 14:00 ` zimoun
2021-03-16 21:47 ` Maxime Devos
2021-03-16 20:53 ` Tobias Geerinckx-Rice
2021-03-16 21:18 ` Vincent Legoll
2021-03-16 21:56 ` Leo Famulari
2021-03-17 6:40 ` Léo Le Bouter
2021-03-30 0:35 ` Léo Le Bouter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3okZ3VWMGnR3r+A1CpdX9JdgTOUdcyi+XZ781DJZLRgdpA9A@mail.gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).