From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UIddB6tYRGHOqwAAgWs5BA (envelope-from ) for ; Fri, 17 Sep 2021 10:58:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0IkCA6tYRGFfCwAAB5/wlQ (envelope-from ) for ; Fri, 17 Sep 2021 08:58:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7AAFB229 for ; Fri, 17 Sep 2021 10:58:18 +0200 (CEST) Received: from localhost ([::1]:57228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR9hJ-0001sO-UA for larch@yhetil.org; Fri, 17 Sep 2021 04:58:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR9h3-0001sC-E0 for guix-devel@gnu.org; Fri, 17 Sep 2021 04:58:02 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:35776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR9gy-00026U-Ur; Fri, 17 Sep 2021 04:58:00 -0400 Received: by mail-qk1-x72e.google.com with SMTP id c7so9766082qka.2; Fri, 17 Sep 2021 01:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LLY1IZVXaM514bsFolrN6WEynG2s83FIRRdF/VqZ94E=; b=fWRji/462E8RRk2N3hYicQypWtjC7N5aYC9gwc/MXx8AcMHhyhYhMD/q0Ot15I0kcH /3BmHvIMmLefatCUFKepRaWOG5dz98h2F/JIcEMtmYHS/k7WfoCW0dnfVXaVxA2+ZBKv UnKj7tOobLQY6d6R9FB+Fwkh1zv1eJtHTrIXiOuP50lavMrVtuq6+MDmw2F2HjmLNtMG tjjJ49OVUxsZqcJ81nr2DG0mw/jOwtu6ghxzTpCUMhJ/tcSenFCLA6ceucunrfsj808a vEdYKL3YGXwKwXNyqB8BmKvoX1T/hzGMJ89oGbco9Sw26GoMzpFQzsVZThb3FQY4uEVe 1xgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LLY1IZVXaM514bsFolrN6WEynG2s83FIRRdF/VqZ94E=; b=jvsBP6x7BE+SiKZ2sRmdk3Ww/ArjZSvBGzeT1KCPwFBVU8y1hjV5Zr1X58F14tyVYe anN/j4NnX+490lJvhJ0MSqn2SVYWn/0f7tZKPol2ANF6M0zSl9AIcR74m56VQXjjFQBm 72h3Sn/+s96RIaq9FBGiTxZnHHz270+7vDDQ2WprYCmJpkV67oeI3zHhDsbAaidYTegE L0aOPMBIAo/3maPIE3SeoZk0TmQVIlAicra8plOBCeC+6zHx4HSiyE0wa9Viz15vPd1J 4+lL6Fu7auAzC5qfSu9Rqwa4Q7Ajsrp7hI9keVcLRQgef8ftTEiUJ1z2V/YWHp+22J9g FamA== X-Gm-Message-State: AOAM533c4JU0Xr3CGN7RXfjdCKEI1lCkkVQov6GrbZT6JePZulcqMKjW Q0LnrOqiWSga6Gmwo0y5uZhacYLTAEeEV8kDB9N/vub+Vas= X-Google-Smtp-Source: ABdhPJy6C6f4SEZT+jodej2HvOzsZAx37GbdtntHZExHxrq6rbmknmVnolHx6A09w5np5EA7KhsuIuldGInyg637u9g= X-Received: by 2002:a37:652:: with SMTP id 79mr9664886qkg.197.1631869073796; Fri, 17 Sep 2021 01:57:53 -0700 (PDT) MIME-Version: 1.0 References: <86pmu1qz2f.fsf@gmail.com> <87a6kv5m1q.fsf@gnu.org> <8735qe23el.fsf@gnu.org> In-Reply-To: <8735qe23el.fsf@gnu.org> From: zimoun Date: Fri, 17 Sep 2021 10:57:42 +0200 Message-ID: Subject: Re: Transform options should error on nonexistant targets To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=zimon.toutoune@gmail.com; helo=mail-qk1-x72e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631869098; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LLY1IZVXaM514bsFolrN6WEynG2s83FIRRdF/VqZ94E=; b=UElmkeRdd9SqHsIKditIlCbkw2sruNG11EMkPX8K3nG6c1qM5jvKP5sXlCHdPflYJPXE5X 6GeQd1x8dR2ev7YcQe1SDbVSwoEzBywGlCy/3ZJZ3AthszlrTloTgwJYGBT9LrQ4aTdlRB Ia2VhJNJZX9vVoLpT+NC2ajk0R2nlo2rQkr/RU8Tu8apnStP2PNvMDrTB/89SpL9LC1XAF 75TxqNyrLXRxT/ISTmFn0WIWs5jFG5pLnD+2MAmbV9ypP+A3ThSNdfYjqNTRaMYR8vhkVD AjWg9kNZCjLDVuJjvJaZVT58HpqQq+rP9+N6yit+zZIctuEkjOV/fwFqWNBU7w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631869098; a=rsa-sha256; cv=none; b=gw4OSRVRsIqbLLBtQwkZP2ohE/zZFDYFfAC4xXsklCUYxBUxOrzWqVV4MW2/Z7Z1pZkhyC P4/HECBM2M+BCjzbSsggXemgrRT69a4mwF4URdwdK1OYf1WT1luaHKBYu/kWPqO3Tmxwmv b0c5UObUnLP0cvdIZpVuz1+t8bRaY5Cc7O5aAgK0xbnEBtAap1J+2Eam0EpXTOvGhnydIJ z/Ru1djsGwIc43lupdNZnZu7vBIFYfgQKIlryPbpsmfXtPnws+gEiEIcMYASr/ZFexTSBu bYEDXwAw0Ava3oZcCSGM2Jd4/DXY0924dk5VaJx6Z4qMsWanjTr9BwRrjw5xIw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="fWRji/46"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="fWRji/46"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: C7AAFB229 X-Spam-Score: -1.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: rlsRY4c+ZW+H Hi, On Wed, 8 Sept 2021 at 22:55, Ludovic Court=C3=A8s wrote: > > Each symbol names a transformation and the corresponding string is an = argument > > to that transformation." > > + (define (package-name? value) > > Rather =E2=80=98assert-package-specification=E2=80=99, since it=E2=80=99s= used for control > effects (exception raised by =E2=80=98specification->package=E2=80=99). Thanks. Indeed, it is better. > > + ;; Return an error if value does not correspond to a package. > > + (match (string-tokenize value %not-equal) > > + ((name _ ...) > > + (specification->package name)))) > > The problem I see is that it prevents rewrites where the package to be > rewritten is not public. Maybe that=E2=80=99s an acceptable tradeoff tho= ugh, > I=E2=80=99m not sure. Yes. It is already used by 'evaluate-replacement-specs' and 'transform-package-toolchain'. That's why I used it. And it appeared to me the simplest. :-) All the best, simon