From mboxrd@z Thu Jan 1 00:00:00 1970 From: zimoun Subject: Re: Guix pull chokes on uglify-js Date: Fri, 29 Nov 2019 16:25:36 +0100 Message-ID: References: <87v9r393i6.fsf@nckx> <87wobjiv7z.fsf@ambrevar.xyz> <87pnhahhh6.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:60682) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iai9X-00045w-Tr for guix-devel@gnu.org; Fri, 29 Nov 2019 10:25:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iai9V-0000X1-GA for guix-devel@gnu.org; Fri, 29 Nov 2019 10:25:50 -0500 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]:42914) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iai9V-0000PO-9U for guix-devel@gnu.org; Fri, 29 Nov 2019 10:25:49 -0500 Received: by mail-qv1-xf32.google.com with SMTP id q19so1883069qvy.9 for ; Fri, 29 Nov 2019 07:25:48 -0800 (PST) In-Reply-To: <87pnhahhh6.fsf@ambrevar.xyz> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Pierre Neidhardt Cc: Guix Devel Hi Pierre, On Fri, 29 Nov 2019 at 15:58, Pierre Neidhardt wrote: > > > By the way, is there a convenient way to catch this kind of errors > > without pushing to master first? > > To answer my own question: > > --8<---------------cut here---------------start------------->8--- > guix pull --url=$HOME/projects/guix --dry-run > --8<---------------cut here---------------end--------------->8--- > > does the trick. This is practical and important enough, I suggest we > add it to the manual in `(guix) 14.6 Submitting Patches'. > > Thoughts? I agree, because it is not the first time that "guix pull" breaks. For example, this commit 41ca406fa54e69f61c55b11ffe5cf465192a907c reverted by this one 74e7465c9b3758c1509a3e0dbe575e2014e20f0a. Document in the manual and maybe add a test in the test-suite (maybe already exist?) All the best, simon