From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cHrGOiAJUWCjRAAA0tVLHw (envelope-from ) for ; Tue, 16 Mar 2021 19:38:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6LRUNiAJUWBWRgAAB5/wlQ (envelope-from ) for ; Tue, 16 Mar 2021 19:38:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5EA0E14F2C for ; Tue, 16 Mar 2021 20:38:08 +0100 (CET) Received: from localhost ([::1]:35026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMFW3-0006hs-Ab for larch@yhetil.org; Tue, 16 Mar 2021 15:38:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMEhz-0002su-Jd for guix-devel@gnu.org; Tue, 16 Mar 2021 14:46:24 -0400 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:35329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMEhs-0003ZX-4f for guix-devel@gnu.org; Tue, 16 Mar 2021 14:46:23 -0400 Received: by mail-qk1-x736.google.com with SMTP id d20so36352959qkc.2 for ; Tue, 16 Mar 2021 11:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gq+sclzKQOO0r13Hg6De7p6OL0IGrhEzJC2umrwHyJY=; b=o+1Vc7DR7vN58q2qjZr9cFDtJEKMYufstaTX7FYclC4b+PDHQlwfUC6FQEKAcn90Dx 94xhdMo+oU1xN6MZwfx0mKHg7QESE0AWOz/TUBplsinttLhLdsh5oLjeNyaR3cEMMq6j jaKiK8LL0R88wZK8kEiLHrKVE8DJ92oSYKCeZEH+xNbi31dg8FEXpHGpa9OzFsfiNQKN S5ks2UUMY4Q9wYMuAcCfmb++RDDMW1x1LhsPmqTVNYZj8udgMVwWBe3RrOmhdN9XGp4O AasgI9mv3elzfFV/pTl6YwlL1/hv7JaVavRP8f3S61t8hFStJrof+p26pZju/94zzZVV 9ZoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gq+sclzKQOO0r13Hg6De7p6OL0IGrhEzJC2umrwHyJY=; b=OjvuJz3q6fTfl6bUmdD6nkZH7x7aYHxujW5b9tA6//ppb7Lm9zSJP6WB0IhRSUCz8+ JLOEURICRYQRuxyEfR60H6fnXDu+ipPu5GcTzGUNVECYA0gkf0h5DxYKbc2Jf/ZkkDDS mkK/Uy01mQli2M4vQgINo25TBdRsuRjp+/i/hqlYXsjWbvgm6wP3bYfX4vb8fc395ezh 1QMORksS5aqLtj7Xhfn8lhhBiBlnz3eGp+mSgLdO7n+hSGgKKHpcchgIfzNi3DAz8E+7 AqpLbKE0qMxTFqyUnFrENALthW3UHSlnxxAO2g5v49pQkRwyZrBaTI0xN8vvPT51L5NT iSsA== X-Gm-Message-State: AOAM5327IxOTZjS7wVlFgZboda0zMkmLa8lSgBLcf8/4xmJCmsXvgx4l 7ktfPRK5EGnYioc53S/bh6KKcw1klPZgsSy8PtE= X-Google-Smtp-Source: ABdhPJxVhlJnZB7Wt4PXfkXcOSp/fEKZ4j4M5uTPe4uJxIe//ELdxGlWPyBKuHCE42KSh5O9otg3iOZlXKxTBOB1sW0= X-Received: by 2002:a05:620a:630:: with SMTP id 16mr516573qkv.304.1615920373731; Tue, 16 Mar 2021 11:46:13 -0700 (PDT) MIME-Version: 1.0 References: <91998d12df3c4a279f46cf50b15d47c99e064a46.camel@zaclys.net> In-Reply-To: From: zimoun Date: Tue, 16 Mar 2021 19:46:02 +0100 Message-ID: Subject: Re: Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates? To: =?UTF-8?Q?L=C3=A9o_Le_Bouter?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::736; envelope-from=zimon.toutoune@gmail.com; helo=mail-qk1-x736.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615923488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=gq+sclzKQOO0r13Hg6De7p6OL0IGrhEzJC2umrwHyJY=; b=PRfhM9UnbRvo7jt0MYl3QqhblzubmEva9oCHAngJ8nbxiE9PRr7Bvw8x9PpHbHjPgZ8USB Q/JohXUQeJhuOppi9lyWlSNGfhxXue9x70A+GhnavpdiMde8dwzIvUjfrr/wjbjCWGBGV4 y+GjQMsv69szbdbfUos9zJT+BSJzHZa5imD6L0ILvyA//9jdl3Ymmr3m3V6PpcqmiaUpdi fiAnzDSYrci9FZcZgBVAeMTh/edjC/1PiBv1pGHNOkpIdFJDb9ZB3H1iyoNLJvWKUCf21O kf58SAcnVN/bBYGHZpAz1DWzNi/1vqf9IPj8UFJfyyDaYyAK5U4nWvbdxDGqTA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615923488; a=rsa-sha256; cv=none; b=GNCloNHaQzts3WALC/Nh6Xs1VFMH0Y3uKH/Klz9hKJXtX6GLyQkJaZaIB9lUP46eh3fY/V x/DZwalmjMyeP+LO7e/ympkBABdMrKUjNjo706SwuwuH4MYoyzLr7XV1wkETN+9umUBlfQ ItvfFwKNLwZ1rrIWSkxtY1C1cX2dBOmE0rDeNBqYt9vvgnI1UBCYSa+6v967I5ntFz3Ltn buNEkP5yEIfSv2fqlMG14/zRlVaWne8OPdtw6hS1yM+mNlKEE23cRB6+rXFHZFCuiCU4LH buvRiqT+8GuDSvm5YqoiTCl68VBjqxuQgd2wwMUrnxSMxtf0BZQgN5efTAMNRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=o+1Vc7DR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=o+1Vc7DR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 5EA0E14F2C X-Spam-Score: -0.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2EyLSdk8lExP On Tue, 16 Mar 2021 at 19:08, L=C3=A9o Le Bouter wrot= e: On Tue, 2021-03-16 at 13:55 -0400, Leo Famulari wrote: > > I do agree that updating this program 5 versions in a graft was > > perhaps > > too much. > > > > We should always try to cherry-pick bug-fix patches when grafting. > > > > Otherwise the risk of breakage is too high. At least, these types of > > patches should be reviewed on guix-patches. L=C3=A9o, can you send them= to > > guix-patches in the future? > > > > Sometimes it is okay to update things in a graft, but it depends on > > the > > situation. > > 1.4.4 and 1.4.9 are ABI compatible? At least that's the reason I > believed it wasnt risky. I can send them to the mailing list especially > with such a core package (GNU Guix dependency). But often it stays > there and no one is looking so. E.g. the unzip vulnerability patches, > nobody looked until I actually pushed them out of waiting for reviews, > I tried to hint multiple people on IRC during several days, no answer > still, so I ended up pushing it, turns out I had several mistakes in it > and because it was pushed well some people looked at it and helped > fixing which was welcome. Well, it seems better to send such changes to guix-patches, waiting 15 days, and then if no comment, push. It is what the manual describes: Non-trivial patches should always be posted to guix-patches@gnu.org (trivial patches include fixing typos, etc.). [=E2=80=A6] For patches that just add a new package, and a simple one, it=E2=80= =99s OK to commit, if you=E2=80=99re confident [=E2=80=A6]. Likewise for pack= age upgrades, except upgrades that trigger a lot of rebuilds [=E2=80=A6]. [=E2=80=A6] [=E2=80=A6] If you didn=E2=80=99t receive any reply after two weeks= , and if you=E2=80=99re confident, it=E2=80=99s OK to commit. And from my understanding, it is a non-trivial patch which triggers a lot of rebuilds. Double reasons. ;-) Cheers, simon