unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Move r-{desolve, quadprog, pracma, subplex} from maths.scm to cran.scm
Date: Fri, 22 Nov 2019 17:03:01 +0100	[thread overview]
Message-ID: <CAJ3okZ0UHGZhLE7aGYSghB88f4e_LzNi+sWhwSMPER-PMT7X2g@mail.gmail.com> (raw)
In-Reply-To: <871ru0c6iq.fsf@elephly.net>

Hi Ricardo,

Thank you for your inputs.

On Fri, 22 Nov 2019 at 15:47, Ricardo Wurmus <rekado@elephly.net> wrote:

> > The packages r-desolve, r-quadprog, r-subplex and r-pracma are defined
> > in `maths.scm`. They come from the CRAN archive. For consistency, they
> > should be defined in the file `cran.scm`. Do you agree to move them?
>
> I think moving them to cran.scm is fine.  In my opinion both of these
> places are similarly poor choices: maths.scm because we drag in the R
> build system and dependencies, and cran.scm because it’s huge and will
> only get bigger.
>
> On the plus side, R code is rarely as “involved” as Python code, so I
> don’t expect cran.scm to become as tangled up with dependencies from all
> over the place as python-xyz.scm, so letting cran.scm grow is probably
> just fine.

Do you agree that we should document this rationale somewhere?
AFAIK, nothing is written down about the lang-xyz.scm or the R land
(cran vs bioconductor vs bioinformatics vs math vs statistiscs).
I will read our materials and come back with a proposal: manual or
cookbook or plain text in repo or etc.
What do you think?


> Since nobody else seems to hold any strong opinions on this issue, I’d
> say you’re welcome to move these package definitions to cran.scm.
> Please also update the Copyright comments at the top of the file where
> needed (use “git blame” and “git log” to simplify this task) and remove
> whatever spurious module imports there may be in maths.scm after
> removing the R package definitions.

I submitted patches [1] that respect these advices. I hope so. :-)

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38184


> PS: I also think that CRAN things in bioinformatics.scm should be moved
> to cran.scm, and even some or all of the R stuff in statistics.scm.
> (Same applies to Bioconductor packages, which should end up in
> bioconductor.scm where possible.)

I will do.
I will dig into the big move of Haskell or Lisp to see how it is
better to split the commits.


Thanks.
simon

  reply	other threads:[~2019-11-22 16:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 15:37 Move r-{desolve,quadprog,pracma,subplex} from maths.scm to cran.scm zimoun
2019-11-07 19:08 ` Move r-{desolve, quadprog, pracma, subplex} " zimoun
2019-11-07 22:42   ` Ricardo Wurmus
2019-11-22 14:47 ` Ricardo Wurmus
2019-11-22 16:03   ` zimoun [this message]
2019-12-09 23:25   ` zimoun
2019-12-10  8:41     ` Ricardo Wurmus
2019-12-10 12:17       ` zimoun
2019-12-10 15:38         ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ3okZ0UHGZhLE7aGYSghB88f4e_LzNi+sWhwSMPER-PMT7X2g@mail.gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).