From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2xhZXMgV2FsbGluICjpn4vlmInoqqAp?= Subject: Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable Date: Tue, 23 Jun 2015 21:52:21 +0200 Message-ID: References: <87r3p2r6od.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7UFL-00074y-3S for guix-devel@gnu.org; Tue, 23 Jun 2015 15:52:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7UFH-0007Ds-Cw for guix-devel@gnu.org; Tue, 23 Jun 2015 15:52:39 -0400 Received: from mail.lysator.liu.se ([2001:6b0:17:f0a0::3]:37178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7UFH-000791-2n for guix-devel@gnu.org; Tue, 23 Jun 2015 15:52:35 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 7AB874000B for ; Tue, 23 Jun 2015 21:52:25 +0200 (CEST) Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 89FEE4000B for ; Tue, 23 Jun 2015 21:52:23 +0200 (CEST) Received: by obbkm3 with SMTP id km3so13366022obb.1 for ; Tue, 23 Jun 2015 12:52:21 -0700 (PDT) In-Reply-To: <87r3p2r6od.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost wrote: > Claes Wallin (=E9=9F=8B=E5=98=89=E8=AA=A0) (2015-06-19 21:51 +0300) wrote= : > I think there is no need in this =E2=86=91 line. The commit message shou= ld be: > > --8<---------------cut here---------------start------------->8--- > gnu: Add pv. > > * gnu/package/pv.scm (pv): New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > --8<---------------cut here---------------end--------------->8--- Ok! > And you also need to add "gnu/package/pv.scm" to "gnu-system.am". See > commit 741115b for example. I will take a look. >> +;;; Copyright 2012, 2013, 2015 Ludovic Courts >> +;;; Copyright 2015 Claes Wallin > > IIUC you are the only author of this file, right? Then there is no > place for Ludovic there. Ok, I copied it from another file and modified it, but if the convention is that the boilerplate is too thin to be credited, I'll remove him. >> + #:export (pv)) >> + >> +(define pv > > I think we prefer 'define-public' over exporting the package variables, > but it is probably not a strong convention. define-public is less redundant. I like it. > I would put "Pipe Viewer" in parentheses: > > "pv (Pipe Viewer) is a terminal-based tool for monitoring the pro= gress > > but I think you may ignore this comment. No, it's a fair point. >> +of data through a pipeline. It can be inserted into any normal pipeline > of data through a pipeline. It can be inserted into any normal pipeli= ne > > I realize that you took this description from the home page, but our > convention is to use two spaces between sentences. If there's a convention I'll follow it. I'll just note here once that I disagree with it. Double space is a type-writer convention that "nobody" follows any more. ;-) Regarding scraping the text I tried quickly to see what license the web site text is under, but didn't find anything conclusive. I figured if Debian is copying it, I should be fine. Maybe I'll get back to checking it later. Thanks for the feedback. I have several more packages in the pipeline once I get this one right! -- /c