From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2xhZXMgV2FsbGluICjpn4vlmInoqqAp?= Subject: Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable Date: Wed, 24 Jun 2015 23:35:00 +0200 Message-ID: References: <87r3p2r6od.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=e89a8f83a8c56e924b05194a47ad Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7sK7-0001Q2-Ur for guix-devel@gnu.org; Wed, 24 Jun 2015 17:35:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7sK1-0002P2-9h for guix-devel@gnu.org; Wed, 24 Jun 2015 17:35:11 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:37022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7sK0-0002Np-Vo for guix-devel@gnu.org; Wed, 24 Jun 2015 17:35:05 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id E53E94003D for ; Wed, 24 Jun 2015 23:35:02 +0200 (CEST) Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 2B08C40018 for ; Wed, 24 Jun 2015 23:35:02 +0200 (CEST) Received: by oiax193 with SMTP id x193so39465543oia.2 for ; Wed, 24 Jun 2015 14:35:00 -0700 (PDT) In-Reply-To: <87r3p2r6od.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel --e89a8f83a8c56e924b05194a47ad Content-Type: text/plain; charset=UTF-8 On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost wrote: > --8<---------------cut here---------------start------------->8--- > gnu: Add pv. > > * gnu/package/pv.scm (pv): New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > --8<---------------cut here---------------end--------------->8--- > > And you also need to add "gnu/package/pv.scm" to "gnu-system.am". See > commit 741115b for example. > IIUC you are the only author of this file, right? Then there is no > place for Ludovic there. > I think we prefer 'define-public' over exporting the package variables, > but it is probably not a strong convention. > I would put "Pipe Viewer" in parentheses: > > "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress > I realize that you took this description from the home page, but our > convention is to use two spaces between sentences. Updated accordingly! -- /c --e89a8f83a8c56e924b05194a47ad Content-Type: application/octet-stream; name="0001-gnu-Add-pv.patch" Content-Disposition: attachment; filename="0001-gnu-Add-pv.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ibba439c0 RnJvbSBlOTNkMjE4ODliZGNiZWQwMmE1MTdmMzBkODQwMWEzYmIxNDRjY2U0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDbGFlcyBXYWxsaW4gPGNsYWVzLndhbGxpbkBncmVhdHNpbm9k ZXZlbG9wbWVudC5jb20+CkRhdGU6IEZyaSwgMTkgSnVuIDIwMTUgMjA6MTI6MDkgKzAyMDAKU3Vi amVjdDogW1BBVENIXSBnbnU6IEFkZCBwdi4KCiAqIGdudS9wYWNrYWdlL3B2LnNjbSAocHYpOiBO ZXcgZmlsZS4KICogZ251LXN5c3RlbS5hbSAoR05VX1NZU1RFTV9NT0RVTEVTKTogQWRkIGl0Lgot LS0KIGdudS1zeXN0ZW0uYW0gICAgICAgfCAgMSArCiBnbnUvcGFja2FnZXMvcHYuc2NtIHwgNDYg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBj aGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgZ251L3BhY2thZ2Vz L3B2LnNjbQoKZGlmZiAtLWdpdCBhL2dudS1zeXN0ZW0uYW0gYi9nbnUtc3lzdGVtLmFtCmluZGV4 IGE0MjBkNzEuLjJhZGZmZDUgMTAwNjQ0Ci0tLSBhL2dudS1zeXN0ZW0uYW0KKysrIGIvZ251LXN5 c3RlbS5hbQpAQCAtMjUzLDYgKzI1Myw3IEBAIEdOVV9TWVNURU1fTU9EVUxFUyA9CQkJCVwKICAg Z251L3BhY2thZ2VzL3B1bXBpby5zY20JCQlcCiAgIGdudS9wYWNrYWdlcy9wcmV0dHktcHJpbnQu c2NtCQkJXAogICBnbnUvcGFja2FnZXMvcHJvdG9idWYuc2NtCQkJXAorICBnbnUvcGFja2FnZXMv cHYuc2NtCQkJCVwKICAgZ251L3BhY2thZ2VzL3B5dGhvbi5zY20JCQlcCiAgIGdudS9wYWNrYWdl cy9xZW11LnNjbQkJCQlcCiAgIGdudS9wYWNrYWdlcy9xdC5zY20JCQkJXApkaWZmIC0tZ2l0IGEv Z251L3BhY2thZ2VzL3B2LnNjbSBiL2dudS9wYWNrYWdlcy9wdi5zY20KbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMC4uOTMyOGRhMwotLS0gL2Rldi9udWxsCisrKyBiL2dudS9wYWNr YWdlcy9wdi5zY20KQEAgLTAsMCArMSw0NiBAQAorOzs7IEdOVSBHdWl4IC0tLSBGdW5jdGlvbmFs IHBhY2thZ2UgbWFuYWdlbWVudCBmb3IgR05VCis7OzsgQ29weXJpZ2h0IMKpIDIwMTUgQ2xhZXMg V2FsbGluIDxjbGFlcy53YWxsaW5AZ3JlYXRzaW5vZGV2ZWxvcG1lbnQuY29tPgorOzs7Cis7Ozsg VGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBmcmVl IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5IGl0Cis7Ozsg dW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJs aXNoZWQgYnkKKzs7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lv biAzIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQKKzs7OyB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZl cnNpb24uCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0 IGl0IHdpbGwgYmUgdXNlZnVsLCBidXQKKzs7OyBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91 dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OzsgTUVSQ0hBTlRBQklMSVRZIG9yIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorOzs7IEdOVSBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCis7OzsKKzs7OyBZb3Ugc2hvdWxkIGhh dmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorOzs7 IGFsb25nIHdpdGggR05VIEd1aXguICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xp Y2Vuc2VzLz4uCisKKyhkZWZpbmUtbW9kdWxlIChnbnUgcGFja2FnZXMgcHYpCisgICM6dXNlLW1v ZHVsZSAoZ3VpeCBsaWNlbnNlcykKKyAgIzp1c2UtbW9kdWxlIChndWl4IHBhY2thZ2VzKQorICAj OnVzZS1tb2R1bGUgKGd1aXggZG93bmxvYWQpCisgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1z eXN0ZW0gZ251KSkKKworKGRlZmluZS1wdWJsaWMgcHYKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAi cHYiKQorICAgICh2ZXJzaW9uICIxLjYuMCIpCisgICAgKHNvdXJjZQorICAgICAob3JpZ2luCisg ICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0dHA6 Ly93d3cuaXZhcmNoLmNvbS9wcm9ncmFtcy9zb3VyY2VzL3B2LSIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgdmVyc2lvbiAiLnRhci5iejIiKSkKKyAgICAgIChzaGEyNTYKKyAgICAgICAoYmFz ZTMyCisgICAgICAgICIxM2dnNnI4NHBrdnpucGQxbDExcXcxanc5eW5hNDBna2dwbmkyNTZraHl4 MjFtNzg1a2hmIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCisgICAg KGhvbWUtcGFnZSAiaHR0cDovL3d3dy5pdmFyY2guY29tL3Byb2dyYW1zL3B2LnNodG1sIikKKyAg ICAoc3lub3BzaXMgIlBpcGVsaW5lIHByb2dyZXNzIGluZGljYXRvciIpCisgICAgKGRlc2NyaXB0 aW9uCisgICAgICJwdiAoUGlwZSBWaWV3ZXIpIGlzIGEgdGVybWluYWwtYmFzZWQgdG9vbCBmb3Ig bW9uaXRvcmluZyB0aGUgcHJvZ3Jlc3MKK29mIGRhdGEgdGhyb3VnaCBhIHBpcGVsaW5lLiAgSXQg Y2FuIGJlIGluc2VydGVkIGludG8gYW55IG5vcm1hbCBwaXBlbGluZQorYmV0d2VlbiB0d28gcHJv Y2Vzc2VzIHRvIGdpdmUgYSB2aXN1YWwgaW5kaWNhdGlvbiBvZiBob3cgcXVpY2tseSBkYXRhIGlz CitwYXNzaW5nIHRocm91Z2gsIGhvdyBsb25nIGl0IGhhcyB0YWtlbiwgaG93IG5lYXIgdG8gY29t cGxldGlvbiBpdCBpcywgYW5kIGFuCitlc3RpbWF0ZSBvZiBob3cgbG9uZyBpdCB3aWxsIGJlIHVu dGlsIGNvbXBsZXRpb24uIikKKyAgICAobGljZW5zZSBhcnRpc3RpYzIuMCkpKQotLSAKMi40LjMK Cg== --e89a8f83a8c56e924b05194a47ad--