From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2xhZXMgV2FsbGluICjpn4vlmInoqqAp?= Subject: Re: [PATCH] Add skalibs, execline. Date: Mon, 29 Jun 2015 11:36:46 +0200 Message-ID: References: <87ioa7sh5v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9VUu-0003V2-Om for guix-devel@gnu.org; Mon, 29 Jun 2015 05:37:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9VUp-00025J-JX for guix-devel@gnu.org; Mon, 29 Jun 2015 05:37:04 -0400 In-Reply-To: <87ioa7sh5v.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel On Jun 28, 2015 10:38 PM, "Ludovic Court=C3=A8s" wrote: > "Claes Wallin (=E9=9F=8B=E5=98=89=E8=AA=A0)" skribis: > > + (search-paths > > + (list (search-path-specification > > + (variable "CPATH") > > + (files '("include"))) > > + (search-path-specification > > + (variable "LIBRARY_PATH") > > + (files '("lib"))))) > > This is not needed here (=E2=80=98gcc=E2=80=99 handles that.) Huh. It seemed to fix something for me, but must be something else I changed then. But that probably explains something else. I'm working on s6, and it expects -lexecline to work. Currently I'm feeding its configure "--with-lib=3D.../lib/execline", would be nice to get that done in execline instead. Modifying LIBRARY_PATH has no effect, what do I need to do to override gcc? > > + (synopsis "Common libraries for skarnet.org software") > > + (description > > + "General-purpose libraries for minimalist C development, used by = all > > + skarnet.org software.") > ^^^^^^ > Please remove extra space here. > > Also, what about something like: > > This package provides lightweight C libraries for features, like data structures and such>. They are used by > skarnet.org software. I'll look into it. > > * gnu/package/skarnet.scm (execline): New variable. > ^ > Extra space. Oops. > > diff --git a/gnu/packages/patches/execline-fix-gen-deps.patch b/gnu/pac= kages/patches/execline-fix-gen-deps.patch > > new file mode 100644 > > index 0000000..79bdc95 > > --- /dev/null > > +++ b/gnu/packages/patches/execline-fix-gen-deps.patch > > @@ -0,0 +1,12 @@ > > Please start the .patch with a brief description of what it does, and > its upstream status (like =E2=80=9CUpstream commit XYZ=E2=80=9D, or =E2= =80=9CSubmitted upstream > at http://...=E2=80=9D.) Ok. I'll rename it too, as s6 turned out to need the same patch as well. It's not guix-specific, they actually don't compile from source. It's funny. > > + #:modules ((guix build utils) > > + (guix build gnu-build-system) > > + (ice-9 popen)) > > Replace the first two with: > > ,@%gnu-build-system-modules Aha, cool. > and use a backquote instead of a quote in =E2=80=98arguments.=E2=80=99 Yeah, of course. > > + "Execline is a (non-interactive) scripting language, like sh, but= its > > +syntax is quite different from a traditional shell syntax. The execli= neb > > +program is used strictly as a parser for a text file and generates a s= ingle > > +command execution with the entire script stored in the argument array. > > +The language is a library of binaries useful for the tail call or > > +chain execution style that the parser requires. > > + > > +It is as powerful as a shell: It features conditional loops, > > +getopt-style option handling, filename globbing, and more. Meanwhile,= its > > +syntax is unambiguous and simple, allowing a minimal parser, which doe= sn't > > +even stay in memory when parsing is done and execution starts."))) > > s/filename/file name/ > It would be nice to make it a couple of lines shorter. Yeah. I'll spend some more effort on removing what can be removed. > > * gnu/package/skarnet.scm (execline): wrap execlineb to have its own > > .../bin first in PATH > > LGTM, but please merge it with the previous patch. Ok. > Could you send updated patches? Will do! > Thank you! Thank *you*! --=20 /c