From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manolis Ragkousis Subject: Re: [PATCH] gnu: base: Add Glibc-Hurd. Date: Fri, 6 Jun 2014 22:23:39 +0000 Message-ID: References: <874n03gfg1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wt2Y1-0005G9-Oy for Guix-devel@gnu.org; Fri, 06 Jun 2014 18:23:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wt2Y0-0003d3-U3 for Guix-devel@gnu.org; Fri, 06 Jun 2014 18:23:41 -0400 In-Reply-To: <874n03gfg1.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel@gnu.org > I believe the =E2=80=98modules=E2=80=99 field can be omitted. Done, I forgot to do that in the first place :P > >> + (propagated-inputs `(("gnumach-headers" ,gnumach-headers) >> + ("hurd-headers" ,hurd-headers) >> + ("hurd-minimal" ,hurd-minimal))) > > Add a one-line comment saying why they=E2=80=99re propagated. Actually I am not sure, should they be propagated? Linux glibc does it this way, because > ;; Glibc's refers to , for instance, so glibc > ;; users should automatically pull Linux headers as well. Should I change it to inputs? > Is --host the only thing that differs from =E2=80=98glibc=E2=80=99? If s= o, we need to > factorize things. In order for glibc/hurd to build, we need to remove > (string-append "--with-headers=3D" > (assoc-ref %build-inputs "linux-headers") > "/include") > "--enable-kernel=3D2.6.30" > ;; XXX: Work around "undefined reference to `__stack_chk_guard'". > "libc_cv_ssp=3Dno" which are linux specific, and add > "--host=3Di686-pc-gnu" > "--disable-profile" > "--disable-multi-arch" > "--disable-nscd" > "--enable-obsolete-rpc" How do you suggest doing it? :-) > However, why do the headers need to be copied in the first place? I > believe the sysdeps headers of add-ons are automatically picked up the > libc=E2=80=99s build system normally. Could you check what=E2=80=99s goi= ng on? When these headers are included, they are used like that > so, while they are normally included in the path, it only looks in the directory "bits/" for them not in libpthread/sysdeps/generic/bits/. Any suggestions? > Remove #t, otherwise the result of =E2=80=98zero?=E2=80=99 is ignored. Done. >> --- /dev/null >> +++ b/gnu/packages/patches/glibc-manual-fix.patch >> @@ -0,0 +1,12 @@ >> +diff --git a/manual/contrib.texi b/manual/contrib.texi >> +index 3b9d23c..376b40d 100644 >> +--- a/manual/contrib.texi >> ++++ b/manual/contrib.texi >> +@@ -1,3 +1,4 @@ >> ++@end deftypefun >> + @node Contributors, Free Manuals, Platform, Top >> + @c %MENU% Who wrote what parts of the GNU C Library >> + @appendix Contributors to @theglibc{} > > What=E2=80=99s this? (Missing explanation.) Without this, I get the error > ./contrib.texi:1: @node seen before @end deftypefun Manolis