From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manolis Ragkousis Subject: Fwd: Re: gnu : add GNU Mig Date: Thu, 20 Feb 2014 17:05:27 +0000 Message-ID: References: <87vbwc8i6y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=f46d043c815e1b14e004f2d983be Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGX44-0003pX-2G for Guix-devel@gnu.org; Thu, 20 Feb 2014 12:05:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGX3x-0002x0-SR for Guix-devel@gnu.org; Thu, 20 Feb 2014 12:05:36 -0500 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:32985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGX3x-0002wg-72 for Guix-devel@gnu.org; Thu, 20 Feb 2014 12:05:29 -0500 Received: by mail-we0-f170.google.com with SMTP id w62so1701961wes.29 for ; Thu, 20 Feb 2014 09:05:28 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Guix-devel@gnu.org --f46d043c815e1b14e004f2d983be Content-Type: multipart/alternative; boundary=f46d043c815e1b14da04f2d983bc --f46d043c815e1b14da04f2d983bc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable By mistake I sent the patch only to ludo ,so I sent it again at guix devel ---------- Forwarded message ---------- From: "Manolis Ragkousis" Date: 20 Feb 2014 15:45 Subject: Re: gnu : add GNU Mig To: "Ludovic Court=E8s" Cc: 1) Fixed the variable and package name to "mig" 2) Fixed the position of the backtick with M-x indent-region to be properly aligned 3) mig is not a binary but a script, but it still needs the build phase. You were right Ludo. 4) I wrapped the lines to ~75 chars 5) I took the description from the GNU mig website and make sync-descriptions doesn't say anything so I guess it's the right one. I hope I did everything right this time :-) 2014-02-18 17:05 GMT+00:00 Ludovic Court=E8s : > Manolis Ragkousis skribis: > > > My second patch for adding GNU Mig. :-D > > Nice! A couple of comments: > > > +(define-public gnumig > > + (package > > + (name "gnumig") > > The variable and package name should be 'mig' ('gnumach' is one of the > exceptions to the rule.) > > > + (arguments > > + `(#:configure-flags '("TARGET_CPPFLAGS=3D-I /include" > "--build=3Di686-pc-gnu") > > Note that the backtick should be aligned with the 'a' of 'arguments'. > If you use Emacs, pass the expression through M-x indent-region. > > > + #:phases (alist-delete > > + 'build > > + %standard-phases) > > What does it do if it doesn't build anything? :-) > That seems wrong to me. > > > + (synopsis "GNU MIG, the Mach interface generator") > > + (description > > + "GNU MIG is the GNU distribution of the Mach 3.0 interface > generator MIG, as maintained by the GNU Hurd developers for the GNU proje= ct. > > +You need this tool to compile the GNU Mach and GNU Hurd distributions, > and to compile the GNU C library for the Hurd. Also, you will need it > > +for other software in the GNU system that uses Mach-based inter-proces= s > communication.") > > Please wrap lines to ~75 characters. > > Also, for GNU software, we use the "official" synopsis and description. > You can run 'make sync-descriptions' to obtain the right for MiG. > > Thanks, > Ludo'. > --f46d043c815e1b14da04f2d983bc Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

By mistake I sent the patch only to ludo ,so I sent it again= at guix devel

---------- Forwarded message ----------
From:= "Manolis Ragkousis" <= manolis837@gmail.com>
Date: 20 Feb 2014 15:45
Subject: Re: gnu= : add GNU Mig
To: "Ludovic Court=E8s" <ludo@= gnu.org>
Cc:

<= div>
1) Fixed the variable and package name to "mig"
2) Fixed the position of the backtick with M-x indent-region to be properl= y aligned
3) mig is not a binary but a script, but it still needs the build pha= se. You were right Ludo.
4) I wrapped the lines to ~75 chars
5) I took the = description from the GNU mig website and make sync-descriptions doesn't= say anything so I guess it's the right one.

I hope I= did everything right this time :-)


2= 014-02-18 17:05 GMT+00:00 Ludovic Court=E8s <ludo@gnu.org>:
=
Manolis Ragkousis <manolis837@gmail.com> skribis:

> My second patch for adding GNU Mig. :-D

Nice!  A couple of comments:

> +(define-public gnumig
> +  (package
> +    (name "gnumig")

The variable and package name should be ‘mig’ (‘gnumach&r= squo; is one of the
exceptions to the rule.)

> +    (arguments
> +    `(#:configure-flags '("TARGET_CPPFLAGS=3D-I /i= nclude" "--build=3Di686-pc-gnu")

Note that the backtick should be aligned with the ‘a’ of &lsquo= ;arguments’.
If you use Emacs, pass the expression through M-x indent-region.

> +      #:phases (alist-delete
> +                'build > +                %standard-pha= ses)

What does it do if it doesn’t build anything?  :-)
That seems wrong to me.

> +    (synopsis "GNU MIG, the Mach interface generator&q= uot;)
> +    (description
> +     "GNU MIG is the GNU distribution of the Mach 3.0 = interface generator MIG, as maintained by the GNU Hurd developers for the G= NU project.
> +You need this tool to compile the GNU Mach and GNU Hurd distributions= , and to compile the GNU C library for the Hurd. Also, you will need it
> +for other software in the GNU system that uses Mach-based inter-proce= ss communication.")

Please wrap lines to ~75 characters.

Also, for GNU software, we use the “official” synopsis and desc= ription.
You can run ‘make sync-descriptions’ to obtain the right for Mi= G.

Thanks,
Ludo’.

--f46d043c815e1b14da04f2d983bc-- --f46d043c815e1b14e004f2d983be Content-Type: text/x-patch; charset=US-ASCII; name="0001_gnu_add_gnumig.patch" Content-Disposition: attachment; filename="0001_gnu_add_gnumig.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hrw75b8s0 RnJvbSBkODZmMjQyYTkxZDVmNmYzNTljOGExOWJkMzJjMmRjN2M1ZTVkZWExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYW5vbGlzIFJhZ2tvdXNpcyA8bWFub2xpczgzN0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMjAgRmViIDIwMTQgMTU6Mjc6MjUgKzAwMDAKU3ViamVjdDogW1BBVENI XSBnbnU6IGh1cmQ6IEFkZCBNaWcuCgoqIGdudS9wYWNrYWdlcy9odXJkLnNjbSAobWlnKTogQWRk IE1pZwotLS0KIGdudS9wYWNrYWdlcy9odXJkLnNjbSB8IDMxICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZ251L3BhY2thZ2VzL2h1cmQuc2NtIGIvZ251L3BhY2thZ2VzL2h1cmQuc2NtCmluZGV4IGY5 MTVlZGEuLjQ1ZjIxNDIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9odXJkLnNjbQorKysgYi9n bnUvcGFja2FnZXMvaHVyZC5zY20KQEAgLTU1LDMgKzU1LDM0IEBACiAgICAgKGRlc2NyaXB0aW9u CiAgICAgICJIZWFkZXJzIG9mIHRoZSBHTlUgTWFjaCBrZXJuZWwuIikKICAgICAobGljZW5zZSBn cGwyKykpKQorCisoZGVmaW5lLXB1YmxpYyBtaWcKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAibWln IikKKyAgICAodmVyc2lvbiAiMS40IikKKyAgICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAg IChtZXRob2QgdXJsLWZldGNoKQorICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAibWlycm9yOi8v Z251L21pZy9taWctIgorICAgICAgICAgICAgICAgICAgICAgICAgICB2ZXJzaW9uICIudGFyLmd6 IikpCisgICAgICAoc2hhMjU2CisgICAgICAgKGJhc2UzMgorICAgICAgICAiMWpnemdnbmJwMjJz YTh6NWRpbG00M3p5MTJ2bGYxcGp4ZmIza2gxM3hyZmhjYXkwbDk3YiIpKSkpCisgICAgKGJ1aWxk LXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgIChpbnB1dHMgYCgoImdudW1hY2gtaGVhZGVy cyIgLGdudW1hY2gtaGVhZGVycykpKQorICAgIChuYXRpdmUtaW5wdXRzCisgICAgIGAoKCJmbGV4 IiAsZmxleCkKKyAgICAgICAoImJpc29uIiAsYmlzb24pKSkKKyAgICAoYXJndW1lbnRzCisgICAg IGAoIzpjb25maWd1cmUtZmxhZ3MgJygiVEFSR0VUX0NQUEZMQUdTPS1JL2luY2x1ZGUiICItLWJ1 aWxkPWk2ODYtcGMtZ251IikKKyAgICAgICAjOnRlc3RzPyAjZikpCisgICAgKGhvbWUtcGFnZSAi aHR0cDovL3d3dy5nbnUub3JnL3NvZnR3YXJlL2h1cmQvbWljcm9rZXJuZWwvbWFjaC9taWcvZ251 X21pZy5odG1sIikKKyAgICAoc3lub3BzaXMgIk1hY2ggMy4wIGludGVyZmFjZSBnZW5lcmF0b3Ig Zm9yIHRoZSBIdXJkIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIkdOVSBNSUcgaXMgdGhlIEdO VSBkaXN0cmlidXRpb24gb2YgdGhlIE1hY2ggMy4wIGludGVyZmFjZSBnZW5lcmF0b3IKK01JRywg YXMgbWFpbnRhaW5lZCBieSB0aGUgR05VIEh1cmQgZGV2ZWxvcGVycyBmb3IgdGhlIEdOVSBwcm9q ZWN0LgorWW91IG5lZWQgdGhpcyB0b29sIHRvIGNvbXBpbGUgdGhlIEdOVSBNYWNoIGFuZCBHTlUg SHVyZCBkaXN0cmlidXRpb25zLAorYW5kIHRvIGNvbXBpbGUgdGhlIEdOVSBDIGxpYnJhcnkgZm9y IHRoZSBIdXJkLiBBbHNvLHlvdSB3aWxsIG5lZWQgaXQKK2ZvciBvdGhlciBzb2Z0d2FyZSBpbiB0 aGUgR05VIHN5c3RlbSB0aGF0IHVzZXMgTWFjaC1iYXNlZCBpbnRlci1wcm9jZXNzCitjb21tdW5p Y2F0aW9uLiIpCisgICAgKGxpY2Vuc2UgZ3BsMispKSkKLS0gCjEuOC41LjMKCg== --f46d043c815e1b14e004f2d983be--