Fwd: Re: gnu : add GNU Mig

[Manolis Ragkousis <manolis837@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2246 bytes --]

By mistake I sent the patch only to ludo ,so I sent it again at guix devel
---------- Forwarded message ----------
From: "Manolis Ragkousis" <manolis837@gmail.com>
Date: 20 Feb 2014 15:45
Subject: Re: gnu : add GNU Mig
To: "Ludovic Courtès" <ludo@gnu.org>
Cc:

1) Fixed the variable and package name to "mig"
2) Fixed the position of the backtick with M-x indent-region to be properly
aligned
3) mig is not a binary but a script, but it still needs the build phase.
You were right Ludo.
4) I wrapped the lines to ~75 chars
5) I took the description from the GNU mig website and make
sync-descriptions doesn't say anything so I guess it's the right one.

I hope I did everything right this time :-)


2014-02-18 17:05 GMT+00:00 Ludovic Courtès <ludo@gnu.org>:

> Manolis Ragkousis <manolis837@gmail.com> skribis:
>
> > My second patch for adding GNU Mig. :-D
>
> Nice!  A couple of comments:
>
> > +(define-public gnumig
> > +  (package
> > +    (name "gnumig")
>
> The variable and package name should be 'mig' ('gnumach' is one of the
> exceptions to the rule.)
>
> > +    (arguments
> > +    `(#:configure-flags '("TARGET_CPPFLAGS=-I /include"
> "--build=i686-pc-gnu")
>
> Note that the backtick should be aligned with the 'a' of 'arguments'.
> If you use Emacs, pass the expression through M-x indent-region.
>
> > +      #:phases (alist-delete
> > +                'build
> > +                %standard-phases)
>
> What does it do if it doesn't build anything?  :-)
> That seems wrong to me.
>
> > +    (synopsis "GNU MIG, the Mach interface generator")
> > +    (description
> > +     "GNU MIG is the GNU distribution of the Mach 3.0 interface
> generator MIG, as maintained by the GNU Hurd developers for the GNU project.
> > +You need this tool to compile the GNU Mach and GNU Hurd distributions,
> and to compile the GNU C library for the Hurd. Also, you will need it
> > +for other software in the GNU system that uses Mach-based inter-process
> communication.")
>
> Please wrap lines to ~75 characters.
>
> Also, for GNU software, we use the "official" synopsis and description.
> You can run 'make sync-descriptions' to obtain the right for MiG.
>
> Thanks,
> Ludo'.
>

[-- Attachment #1.2: Type: text/html, Size: 3339 bytes --]

[-- Attachment #2: 0001_gnu_add_gnumig.patch --]
[-- Type: text/x-patch, Size: 1756 bytes --]

From d86f242a91d5f6f359c8a19bd32c2dc7c5e5dea1 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Thu, 20 Feb 2014 15:27:25 +0000
Subject: [PATCH] gnu: hurd: Add Mig.

* gnu/packages/hurd.scm (mig): Add Mig
---
 gnu/packages/hurd.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/hurd.scm b/gnu/packages/hurd.scm
index f915eda..45f2142 100644
--- a/gnu/packages/hurd.scm
+++ b/gnu/packages/hurd.scm
@@ -55,3 +55,34 @@
     (description
      "Headers of the GNU Mach kernel.")
     (license gpl2+)))
+
+(define-public mig
+  (package
+    (name "mig")
+    (version "1.4")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://gnu/mig/mig-"
+                          version ".tar.gz"))
+      (sha256
+       (base32
+        "1jgzggnbp22sa8z5dilm43zy12vlf1pjxfb3kh13xrfhcay0l97b"))))
+    (build-system gnu-build-system)
+    (inputs `(("gnumach-headers" ,gnumach-headers)))
+    (native-inputs
+     `(("flex" ,flex)
+       ("bison" ,bison)))
+    (arguments
+     `(#:configure-flags '("TARGET_CPPFLAGS=-I/include" "--build=i686-pc-gnu")
+       #:tests? #f))
+    (home-page "http://www.gnu.org/software/hurd/microkernel/mach/mig/gnu_mig.html")
+    (synopsis "Mach 3.0 interface generator for the Hurd")
+    (description
+     "GNU MIG is the GNU distribution of the Mach 3.0 interface generator
+MIG, as maintained by the GNU Hurd developers for the GNU project.
+You need this tool to compile the GNU Mach and GNU Hurd distributions,
+and to compile the GNU C library for the Hurd. Also,you will need it
+for other software in the GNU system that uses Mach-based inter-process
+communication.")
+    (license gpl2+)))
-- 
1.8.5.3