From: Manolis Ragkousis <manolis837@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <Guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: base: Add Glibc-Hurd Headers.
Date: Sat, 27 Sep 2014 16:50:02 +0300 [thread overview]
Message-ID: <CAFtzXzNv6M7cOSaTs3KDQ0AvkSETz-GL1YfppLWDoDC4BVO_kg@mail.gmail.com> (raw)
In-Reply-To: <87y4t5if3q.fsf@gnu.org>
>> And thread_terminate does exist, that's why it's enough for our needs.
>
> You mean ‘thread_terminate_release’?
Okay, let me explain it a bit better
Here is the part we are interested in
"libpthread/sysdeps/mach/pt-thread-terminate.c"
/* Terminate and release all that's left. */
err = __thread_terminate_release (kernel_thread, mach_task_self (),
kernel_thread, reply_port,
stackaddr, stacksize);
/* The kernel does not support it yet. Leak but at least terminate
correctly. */
err = __thread_terminate (kernel_thread);
The comment "The kernel does not support it yet." is misleading.
It wants to say that __thread_terminate_release is not yet supported
so __thread_terminate can be used instead, to at least terminate it
correctly, even though we will have leaks.
That's why Samuel told me here
http://lists.gnu.org/archive/html/bug-hurd/2014-05/msg00127.html
> Manolis Ragkousis, le Thu 15 May 2014 21:08:41 +0000, a écrit :
> > So I commented the part that calls this function out and glibc gets
> > built succefully with libpthread.
> > > err = __thread_terminate_release (kernel_thread, mach_task_self (),
>
> That should be fine, yes, IIRC I left a thread_terminate call just
> below, which should work enough for your needs.
Manolis
next prev parent reply other threads:[~2014-09-27 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 21:16 [PATCH] gnu: base: Add Glibc-Hurd Headers Manolis Ragkousis
2014-08-29 13:48 ` Ludovic Courtès
2014-09-24 13:01 ` Manolis Ragkousis
2014-09-27 9:31 ` Ludovic Courtès
2014-09-27 13:50 ` Manolis Ragkousis [this message]
2014-09-27 17:30 ` Manolis Ragkousis
2014-09-28 9:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFtzXzNv6M7cOSaTs3KDQ0AvkSETz-GL1YfppLWDoDC4BVO_kg@mail.gmail.com \
--to=manolis837@gmail.com \
--cc=Guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).