unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Felix Lechner via "Development of GNU Guix and the GNU System distribution." <guix-devel@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Understanding a Golang importer error
Date: Wed, 24 May 2023 19:29:02 -0700	[thread overview]
Message-ID: <CAFHYt55pDYrx-oTQLX9J3tB37p=3CFx6_gxqeT0_Di7HwDq9Sg@mail.gmail.com> (raw)
In-Reply-To: <87o7mcxrev.fsf@gmail.com>

Hi Simon,

On Mon, May 22, 2023 at 10:02 AM Simon Tournier
<zimon.toutoune@gmail.com> wrote:
>
> Using submission #63647 [1], now it raises:
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix import go -r github.com/google/certificate-transparency-go
> guix import: warning: Git error: reference 'refs/tags/v0.41.1' not found in https://github.com/open-telemetry/opentelemetry-go-contrib
> guix import: warning: Git error: reference 'refs/tags/v2.305.9' not found in https://github.com/etcd-io/etcd
> following redirection to `https://github.com/bufbuild/protoc-gen-validate?go-get=1'...
> guix import: warning: Git error: reference 'refs/tags/v1.9.1' not found in https://github.com/googleapis/google-cloud-go
> guix import: warning: Git error: reference 'refs/tags/v1.14.0' not found in https://github.com/googleapis/google-cloud-go
> guix import: warning: Git error: reference 'refs/tags/v1.19.3' not found in https://github.com/googleapis/google-cloud-go
> --8<---------------cut here---------------end--------------->8---
>
> Note that these warnings are non-blocking and thus a list of Guix
> packages can be generated, although some are partial.

Thank you so much! That patch takes the cake and probably deserves to
become the accepted answer.

I would find it more consistent, however, to pick a nearby version (or
the newest version) and emit that package definition, instead.

After all, Guix package variables do not care about versions, and
neither do we. Guix and its contributors assume more or less
throughout that nearby versions work fine. Why not here, too?

We could also prompt the user of 'guix import' to select a tag.

> Well, I do not know if we can do better.  I mean, the issue seems about
> a wrong packaging upstream.  I mean, the tag v0.41.1 is reported as
> metadata from goproxy (https://proxy.golang.org) but then the real Git
> repository of the package does not contain it.

There must be a convention that were are missing. The repositories
contain hundreds and sometimes thousands of Git tags that look like
file paths. The version number we recognize are at the very end. At
the other end of the weirdness spectrum is the speculation by folks on
#go-nuts that the missing tags were subsequently deleted.

Do the versions perhaps come from the consuming go.mod files that
spell out the version requirements?

Kind regards,
Felix


  reply	other threads:[~2023-05-25  2:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  3:13 Understanding a Golang importer error Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-05-22  6:38 ` Csepp
2023-05-22 14:44 ` Attila Lendvai
2023-05-22 16:27 ` Simon Tournier
2023-05-25  2:29   ` Felix Lechner via Development of GNU Guix and the GNU System distribution. [this message]
2023-05-25 14:09     ` Simon Tournier
2023-05-25 16:02       ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFHYt55pDYrx-oTQLX9J3tB37p=3CFx6_gxqeT0_Di7HwDq9Sg@mail.gmail.com' \
    --to=guix-devel@gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).