From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Legoll Subject: Re: [PACKAGE] musl libc Date: Tue, 2 Aug 2016 22:18:13 +0200 Message-ID: References: <87shun46de.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUg8n-00014m-84 for guix-devel@gnu.org; Tue, 02 Aug 2016 16:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUg8k-0000Nn-Su for guix-devel@gnu.org; Tue, 02 Aug 2016 16:18:16 -0400 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:35808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUg8k-0000Nc-NN for guix-devel@gnu.org; Tue, 02 Aug 2016 16:18:14 -0400 Received: by mail-qk0-x236.google.com with SMTP id s63so185954317qkb.2 for ; Tue, 02 Aug 2016 13:18:14 -0700 (PDT) In-Reply-To: <87shun46de.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel > It=E2=80=99s fine to put it in a separate file =E2=80=9Cgnu/packages/musl= .scm=E2=80=9D and add > it to the list of modules in =E2=80=9Cgnu/local.mk=E2=80=9D. > > What follows is a short review with some comments. > >> (synopsis "New C standard library to power a new generation of >> Linux-based devices") > > I would change it to just =E2=80=9CSmall C standard library=E2=80=9D. Wh= at do you > think? As you wish I just copied it from upstream web site... >> (description "The musl libc is lightweight, fast, simple, free, and = strives >> to be correct in the sense of standards-conformance and safety.") > > How about this instead? > > =E2=80=9Cmusl is a simple and lightweight C standard library. It str= ives to > be correct in the sense of standards-conformance and safety.=E2=80= =9D > > =E2=80=9Cfast=E2=80=9D is a bit of a loaded term, so we often avoid it. = Since all > packages in Guix are =E2=80=9Cfree=E2=80=9D we usually drop this term fro= m descriptions. Ditto >> (home-page "http://www.musl-libc.org") >> (license (x11-style "file://COPYRIGHT")))) > > This looks good. If you agree, I=E2=80=99ll copy the changes and make a = commit > with you as the author. > > Normally, contributors send changes as patches to the mailing list. For > future contributions it might be helpful to take a look at the > =E2=80=9CContributing=E2=80=9D section in the manual: Yes, I just wanted feedback in order to make a real patch submission afterw= ards, and thought it would be more readable as is, and I didn't know in which file to put it anyways... But if you want to do it, go ahead... > https://www.gnu.org/software/guix/manual/html_node/Contributing.html > > This essentially describes how to get started with Guix from a git > clone, generate patches with =E2=80=9Cgit format-patch=E2=80=9D and how t= o send them via > email. If anything in there is confusing to you please let us know and > we=E2=80=99ll try to help. This is clear enough > You=E2=80=99re also welcome to visit the #guix IRC channel > on Freenode for discussions or questions. Yep, even if I'm not a big fan of irc, I already came to this channel a few times Thanks --=20 Vincent Legoll