From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Legoll Subject: Re: none Date: Fri, 22 Jul 2016 16:15:51 +0200 Message-ID: References: <579027b7.VHXjhpPxQC3AAmeY%pjotr.public12@email> <8760rznoh1.fsf@gnu.org> <20160722004130.GA10340@thebird.nl> <87k2gexf4l.fsf@gnu.org> <20160722140708.GA2882@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQbF7-0000oi-BA for guix-devel@gnu.org; Fri, 22 Jul 2016 10:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQbF5-0001u0-C1 for guix-devel@gnu.org; Fri, 22 Jul 2016 10:15:56 -0400 In-Reply-To: <20160722140708.GA2882@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel On Fri, Jul 22, 2016 at 4:07 PM, Leo Famulari wrote: >> You've seen the mistakes I made, and the little syntactic things that >> kept going wrong over time. Near the end of my internship, however, I >> saw a positive change: Reviewers actually make little changes, instead >> of leaving it up to the submitter to ``fix the indendation''. This >> change makes the burden of reviewing smaller as well as the burden to >> submit a package. Great! > > That's good. I think there is some value in asking submitters to correct > even small issues, so that they have a chance to learn. But, the faster > method is for the reviewer to make the correction themselves, and then > explain the difference. If there are many minor changes, the reviewer > can attach a diff to their reply. That's a matter of taste, I prefer being told that my contribution is not g= ood enough and then fix it myself, but that's because I'm not doing a lot... If the maintainer wants to do additional changes, I also prefer he does it = in a separate patch/commit, as that would enable me to git pull --ff instead o= f merge... my .02=E2=82=AC --=20 Vincent Legoll