From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Legoll Subject: Re: native or not Date: Tue, 31 Mar 2020 00:07:03 +0200 Message-ID: References: <87a73ypbyb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000076ebcb05a219ac14" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:48266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJ2Yv-0003iv-RF for guix-devel@gnu.org; Mon, 30 Mar 2020 18:07:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJ2Yu-0007tg-0v for guix-devel@gnu.org; Mon, 30 Mar 2020 18:07:17 -0400 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]:35125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJ2Yt-0007sF-Pt for guix-devel@gnu.org; Mon, 30 Mar 2020 18:07:15 -0400 Received: by mail-io1-xd2f.google.com with SMTP id o3so14010163ioh.2 for ; Mon, 30 Mar 2020 15:07:15 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Mathieu Othacehe Cc: guix-devel --00000000000076ebcb05a219ac14 Content-Type: text/plain; charset="UTF-8" Here is a set of patches, for starting discussion... I only build-tested them natively on/for x86_64 (and cross built for aarch64 for the sudo one) On Mon, Mar 30, 2020 at 11:25 PM Vincent Legoll wrote: > > Hello Mathieu, > > On Mon, Mar 30, 2020 at 8:57 AM Mathieu Othacehe wrote: > > > Are those changes useful to do on their own ? > > > > Well yes it may reduce the closure size of the package (run `guix size > > sudo`) to get it. > > I'm not seeing any size difference, but groff is not in the output: > > on master, groff in inputs: > > $ ./pre-inst-env guix size sudo > store item total self > /gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4pj-glibc-2.29 > 37.4 35.8 36.9% > /gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib > 70.0 32.6 33.7% > /gnu/store/9kzrrccpzl6i1sfwb0drb00gi2gwk0x0-coreutils-8.31 > 90.0 16.5 17.0% > /gnu/store/vsvba1ilj2zj536pvsil6r0mf5rnjj45-sudo-1.8.31p1 > 96.9 3.5 3.6% > /gnu/store/dvs3acxwfnwgc7yma6h3y937ri2li47y-gmp-6.1.2 > 72.6 2.6 2.7% > /gnu/store/vkj5rdiavl87m21d9i0k69rfw79p13gj-linux-pam-1.3.1 > 73.2 2.1 2.2% > /gnu/store/cp72ncw4prnsga65n3pzll07hpsg524f-bash-static-5.0.7 > 1.6 1.6 1.7% > /gnu/store/29jhbbg1hf557x8j53f9sxd9imlmf02a-bash-minimal-5.0.7 > 38.4 1.0 1.1% > /gnu/store/nffbgghxyvrj29lcgxs5fpmi3sx9zzql-acl-2.2.53 > 70.7 0.5 0.5% > /gnu/store/in1738m2zvhgpz78n2yqa972sdzc42ss-attr-2.4.48 > 70.3 0.3 0.3% > /gnu/store/qx7p7hiq90mi7r78hcr9cyskccy2j4bg-zlib-1.2.11 > 70.2 0.2 0.2% > /gnu/store/waw5ci4lazbf2a1x9v6gw1v274nk0gny-libcap-2.27 > 70.2 0.2 0.2% > total: 96.9 MiB > > on a branch with groff in native-inputs: > > $ ./pre-inst-env guix size sudo > store item total self > /gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4pj-glibc-2.29 > 37.4 35.8 36.9% > /gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib > 70.0 32.6 33.7% > /gnu/store/9kzrrccpzl6i1sfwb0drb00gi2gwk0x0-coreutils-8.31 > 90.0 16.5 17.0% > /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1 > 96.9 3.5 3.6% > /gnu/store/dvs3acxwfnwgc7yma6h3y937ri2li47y-gmp-6.1.2 > 72.6 2.6 2.7% > /gnu/store/vkj5rdiavl87m21d9i0k69rfw79p13gj-linux-pam-1.3.1 > 73.2 2.1 2.2% > /gnu/store/cp72ncw4prnsga65n3pzll07hpsg524f-bash-static-5.0.7 > 1.6 1.6 1.7% > /gnu/store/29jhbbg1hf557x8j53f9sxd9imlmf02a-bash-minimal-5.0.7 > 38.4 1.0 1.1% > /gnu/store/nffbgghxyvrj29lcgxs5fpmi3sx9zzql-acl-2.2.53 > 70.7 0.5 0.5% > /gnu/store/in1738m2zvhgpz78n2yqa972sdzc42ss-attr-2.4.48 > 70.3 0.3 0.3% > /gnu/store/qx7p7hiq90mi7r78hcr9cyskccy2j4bg-zlib-1.2.11 > 70.2 0.2 0.2% > /gnu/store/waw5ci4lazbf2a1x9v6gw1v274nk0gny-libcap-2.27 > 70.2 0.2 0.2% > total: 96.9 MiB > > > It can also fix cross-compilation. Because when cross-compiling, if > > groff needs to be run at build-time, it needs to be for the native > > architecture and not the target one. > > > > You can check it by running `guix build --target=aarch64-linux-gnu sudo` > > for instance. > > That fails on master (libpaper) whereas with the patch it works, > so I guess the patch is useful on that front. > > The patch for sudo will be in the following emails. > > Is there anything else to check / test ? > > -- > Vincent Legoll -- Vincent Legoll --00000000000076ebcb05a219ac14 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-privoxy-Make-some-inputs-native.patch" Content-Disposition: attachment; filename="0001-gnu-privoxy-Make-some-inputs-native.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k8f0uotd0 RnJvbSBhNzgyODE2ZmUwOTZlNzg2NjczYzAzZGNhM2IyODY2ZTYyOTMzZmZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5jZW50IExlZ29sbCA8dmluY2VudC5sZWdvbGxAZ21haWwu Y29tPgpEYXRlOiBNb24sIDMwIE1hciAyMDIwIDIyOjIxOjA4ICswMjAwClN1YmplY3Q6IFtQQVRD SCAxLzRdIGdudTogcHJpdm94eTogTWFrZSBzb21lIGlucHV0cyBuYXRpdmUuCgoqIGdudS9wYWNr YWdlcy90b3Iuc2NtIChwcml2b3h5KVtuYXRpdmUtaW5wdXRzXTogTmV3IGZpZWxkLgpbaW5wdXRz XTogTW92ZSBhdXRvY29uZiAmIGF1dG9tYWtlIHRvIG5hdGl2ZS1pbnB1dHMuCi0tLQogZ251L3Bh Y2thZ2VzL3Rvci5zY20gfCA1ICsrKy0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy90b3Iuc2NtIGIvZ251 L3BhY2thZ2VzL3Rvci5zY20KaW5kZXggNjFlNTJiYTIyYy4uODQxMTU4ODcxZSAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL3Rvci5zY20KKysrIGIvZ251L3BhY2thZ2VzL3Rvci5zY20KQEAgLTE0 MSw4ICsxNDEsOSBAQCByZWplY3RzIFVEUCB0cmFmZmljIGZyb20gdGhlIGFwcGxpY2F0aW9uIHlv dSdyZSB1c2luZy4iKQogICAgIChpbnB1dHMKICAgICAgYCgoInczbSIgLHczbSkKICAgICAgICAo InBjcmUiICxwY3JlKQotICAgICAgICgiemxpYiIgLHpsaWIpCi0gICAgICAgKCJhdXRvY29uZiIg LGF1dG9jb25mKQorICAgICAgICgiemxpYiIgLHpsaWIpKSkKKyAgICAobmF0aXZlLWlucHV0cwor ICAgICBgKCgiYXV0b2NvbmYiICxhdXRvY29uZikKICAgICAgICAoImF1dG9tYWtlIiAsYXV0b21h a2UpKSkKICAgICAoaG9tZS1wYWdlICJodHRwczovL3d3dy5wcml2b3h5Lm9yZyIpCiAgICAgKHN5 bm9wc2lzICJXZWIgcHJveHkgd2l0aCBhZHZhbmNlZCBmaWx0ZXJpbmcgY2FwYWJpbGl0aWVzIGZv ciBlbmhhbmNpbmcgcHJpdmFjeSIpCi0tIAoyLjI1LjIKCg== --00000000000076ebcb05a219ac14 Content-Type: text/x-patch; charset="US-ASCII"; name="0004-gnu-procenv-Make-some-inputs-native-make-multiline.patch" Content-Disposition: attachment; filename="0004-gnu-procenv-Make-some-inputs-native-make-multiline.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k8f0uoto3 RnJvbSAzODg3NTM4ZDM3MjU2NDI0ZDU2NTRkYTVmY2U0Yzk0YzkyNGE0ZTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5jZW50IExlZ29sbCA8dmluY2VudC5sZWdvbGxAZ21haWwu Y29tPgpEYXRlOiBNb24sIDMwIE1hciAyMDIwIDIyOjQyOjI4ICswMjAwClN1YmplY3Q6IFtQQVRD SCA0LzRdIGdudTogcHJvY2VudjogTWFrZSBzb21lIGlucHV0cyBuYXRpdmUgJiBtYWtlIG11bHRp bGluZS4KCiogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSAocHJvY2VudilbbmF0aXZlLWlucHV0c106 IE5ldyBmaWVsZC4KW2lucHV0c106IE1vdmUgZ3JvZmYgdG8gbmF0aXZlLWlucHV0cywgbW92ZSBl YWNoIHJlbWFpbmluZyBpdGVtIG9uIGl0cyBvd24gbGluZS4KLS0tCiBnbnUvcGFja2FnZXMvbGlu dXguc2NtIHwgOCArKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvbGludXguc2NtIGIvZ251L3Bh Y2thZ2VzL2xpbnV4LnNjbQppbmRleCBhNDU4NDdjYmU1Li45NDVjMTVkOTcyIDEwMDY0NAotLS0g YS9nbnUvcGFja2FnZXMvbGludXguc2NtCisrKyBiL2dudS9wYWNrYWdlcy9saW51eC5zY20KQEAg LTU4NjcsOSArNTg2NywxMSBAQCB0aGUgTVRQIGRldmljZSBhcyBhIGZpbGUgc3lzdGVtLiIpCiAg ICAgICAoYmFzZTMyICIxamF2dzk3eXcwcXZqbWoxNGpzOHZ3Nm5zZnlmMnhjMGtmaXlxNWYyaHNw MDU1M3cyY2RxIikpKSkKICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKICAgIChh cmd1bWVudHMgYCgjOmNvbmZpZ3VyZS1mbGFncyAnKCItLWRpc2FibGUtc2lsZW50LXJ1bGVzIikp KQotICAgKG5hdGl2ZS1pbnB1dHMgYCgoInBrZy1jb25maWciICxwa2ctY29uZmlnKSkpCi0gICAo aW5wdXRzIGAoKCJleHBhdCIgLGV4cGF0KSAoImxpYmNhcCIgLGxpYmNhcCkgKCJjaGVjayIgLGNo ZWNrKQotICAgICAgICAgICAgICgiZ3JvZmYiICxncm9mZikgICAgICAgICAgIDsgZm9yIHRlc3Rz CisgICAobmF0aXZlLWlucHV0cyBgKCgiZ3JvZmYiICxncm9mZikgOyBmb3IgdGVzdHMKKyAgICAg ICAgICAgICAgICAgICAgKCJwa2ctY29uZmlnIiAscGtnLWNvbmZpZykpKQorICAgKGlucHV0cyBg KCgiY2hlY2siICxjaGVjaykKKyAgICAgICAgICAgICAoImV4cGF0IiAsZXhwYXQpCisgICAgICAg ICAgICAgKCJsaWJjYXAiICxsaWJjYXApCiAgICAgICAgICAgICAgKCJsaWJzZWxpbnV4IiAsbGli c2VsaW51eCkpKQogICAgKHN5bm9wc2lzICJVdGlsaXR5IHRvIHNob3cgcHJvY2VzcyBlbnZpcm9u bWVudCIpCiAgICAoZGVzY3JpcHRpb24gIlByb2NlbnYgaXMgYSBjb21tYW5kLWxpbmUgdG9vbCB0 aGF0IGRpc3BsYXlzIGFzIG11Y2ggZGV0YWlsIGFib3V0Ci0tIAoyLjI1LjIKCg== --00000000000076ebcb05a219ac14 Content-Type: text/x-patch; charset="US-ASCII"; name="0003-gnu-nftables-Make-some-inputs-native.patch" Content-Disposition: attachment; filename="0003-gnu-nftables-Make-some-inputs-native.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k8f0uotn2 RnJvbSA2MGU0MDBjYzc4YTZmMmNhZjk5MTgwMGExMzYyMjkwNmI2ZTZkYWJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5jZW50IExlZ29sbCA8dmluY2VudC5sZWdvbGxAZ21haWwu Y29tPgpEYXRlOiBNb24sIDMwIE1hciAyMDIwIDIyOjM4OjQ0ICswMjAwClN1YmplY3Q6IFtQQVRD SCAzLzRdIGdudTogbmZ0YWJsZXM6IE1ha2Ugc29tZSBpbnB1dHMgbmF0aXZlLgoKKiBnbnUvcGFj a2FnZXMvbGludXguc2NtIChwcm9jZW52KVtuYXRpdmUtaW5wdXRzXTogTmV3IGZpZWxkLgpbaW5w dXRzXTogTW92ZSBiaXNvbiAmIGZsZXggdG8gbmF0aXZlLWlucHV0cy4KLS0tCiBnbnUvcGFja2Fn ZXMvbGludXguc2NtIHwgOCArKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvbGludXguc2NtIGIv Z251L3BhY2thZ2VzL2xpbnV4LnNjbQppbmRleCA3MDFkZjc2NGNkLi5hNDU4NDdjYmU1IDEwMDY0 NAotLS0gYS9nbnUvcGFja2FnZXMvbGludXguc2NtCisrKyBiL2dudS9wYWNrYWdlcy9saW51eC5z Y20KQEAgLTU2NDcsMTMgKzU2NDcsMTMgQEAgdXNlZCBieSBuZnRhYmxlcy4iKQogICAgIChidWls ZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKICAgICAoYXJndW1lbnRzIGAoIzpjb25maWd1cmUt ZmxhZ3MKICAgICAgICAgICAgICAgICAgJygiLS1kaXNhYmxlLW1hbi1kb2MiKSkpIDsgRklYTUU6 IE5lZWRzIGRvY2Jvb2syeC4KLSAgICAoaW5wdXRzIGAoKCJiaXNvbiIgLGJpc29uKQotICAgICAg ICAgICAgICAoImZsZXgiICxmbGV4KQotICAgICAgICAgICAgICAoImdtcCIgLGdtcCkKKyAgICAo aW5wdXRzIGAoKCJnbXAiICxnbXApCiAgICAgICAgICAgICAgICgibGlibW5sIiAsbGlibW5sKQog ICAgICAgICAgICAgICAoImxpYm5mdG5sIiAsbGlibmZ0bmwpCiAgICAgICAgICAgICAgICgicmVh ZGxpbmUiICxyZWFkbGluZSkpKQotICAgIChuYXRpdmUtaW5wdXRzIGAoKCJwa2ctY29uZmlnIiAs cGtnLWNvbmZpZykpKQorICAgIChuYXRpdmUtaW5wdXRzIGAoKCJwa2ctY29uZmlnIiAscGtnLWNv bmZpZykKKyAgICAgICAgICAgICAgICAgICAgICgiYmlzb24iICxiaXNvbikKKyAgICAgICAgICAg ICAgICAgICAgICgiZmxleCIgLGZsZXgpKSkKICAgICAoaG9tZS1wYWdlICJodHRwczovL3d3dy5u ZnRhYmxlcy5vcmciKQogICAgIChzeW5vcHNpcyAiVXNlcnNwYWNlIHV0aWxpdHkgZm9yIExpbnV4 IHBhY2tldCBmaWx0ZXJpbmciKQogICAgIChkZXNjcmlwdGlvbiAibmZ0YWJsZXMgaXMgdGhlIHBy b2plY3QgdGhhdCBhaW1zIHRvIHJlcGxhY2UgdGhlIGV4aXN0aW5nCi0tIAoyLjI1LjIKCg== --00000000000076ebcb05a219ac14 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-gnu-sudo-Make-some-inputs-native.patch" Content-Disposition: attachment; filename="0002-gnu-sudo-Make-some-inputs-native.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k8f0uotl1 RnJvbSBiZDJmOWNhYzkyMjliYjMxY2M2NGY1ZDY0N2I2ZWY4MDg1ZjQ2ZGI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5jZW50IExlZ29sbCA8dmluY2VudC5sZWdvbGxAZ21haWwu Y29tPgpEYXRlOiBNb24sIDMwIE1hciAyMDIwIDIyOjI4OjU1ICswMjAwClN1YmplY3Q6IFtQQVRD SCAyLzRdIGdudTogc3VkbzogTWFrZSBzb21lIGlucHV0cyBuYXRpdmUuCgoqIGdudS9wYWNrYWdl cy9hZG1pbi5zY20gKHN1ZG8pW25hdGl2ZS1pbnB1dHNdOiBOZXcgZmllbGQuCltpbnB1dHNdOiBN b3ZlIGdyb2ZmIHRvIG5hdGl2ZS1pbnB1dHMuCi0tLQogZ251L3BhY2thZ2VzL2FkbWluLnNjbSB8 IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2FkbWluLnNjbSBiL2dudS9wYWNrYWdlcy9hZG1p bi5zY20KaW5kZXggMmY2NjFmNWU4MS4uNDU3ZGMxZTNkYyAxMDA2NDQKLS0tIGEvZ251L3BhY2th Z2VzL2FkbWluLnNjbQorKysgYi9nbnUvcGFja2FnZXMvYWRtaW4uc2NtCkBAIC0xMjY4LDkgKzEy NjgsMTAgQEAgc3lzdGVtIGFkbWluaXN0cmF0b3IuIikKICAgICAgICA7OyBYWFg6IFRoZSAndGVz dHN1ZG9lcnMnIHRlc3Qgc2VyaWVzIGV4cGVjdHMgdXNlciAncm9vdCcgdG8gZXhpc3QsIGJ1dAog ICAgICAgIDs7IHRoZSBjaHJvb3QncyAvZXRjL3Bhc3N3ZCBkb2Vzbid0IGhhdmUgaXQuICBUdXJu IG9mZiB0aGUgdGVzdHMuCiAgICAgICAgIzp0ZXN0cz8gI2YpKQorICAgIChuYXRpdmUtaW5wdXRz CisgICAgIGAoKCJncm9mZiIgLGdyb2ZmKSkpCiAgICAgKGlucHV0cwotICAgICBgKCgiZ3JvZmYi ICxncm9mZikKLSAgICAgICAoImxpbnV4LXBhbSIgLGxpbnV4LXBhbSkKKyAgICAgYCgoImxpbnV4 LXBhbSIgLGxpbnV4LXBhbSkKICAgICAgICAoInpsaWIiICx6bGliKQogICAgICAgICgiY29yZXV0 aWxzIiAsY29yZXV0aWxzKSkpCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly93d3cuc3Vkby53cy8i KQotLSAKMi4yNS4yCgo= --00000000000076ebcb05a219ac14--