From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent Legoll <vincent.legoll@gmail.com>
Subject: Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to
	'inputs-should-be-native'.
Date: Thu, 21 Jul 2016 15:22:50 +0200
Message-ID: <CAEwRq=oEkabsVRBuxYAHqd3AXBJ-bA_Wi-W1ebh1UCYb3OeFXw@mail.gmail.com>
References: <20160719164916.6597-1-david@craven.ch>
	<20160719164916.6597-2-david@craven.ch> <87r3aobnoi.fsf@gnu.org>
	<CAL1_immZV=_J6ZmGqyUs5bP3x_f-weUvPp4E4unViTtZ0OwjdA@mail.gmail.com>
	<87y44vnpq3.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vincent.legoll@gmail.com>) id 1bQDwD-0001qT-QD
	for guix-devel@gnu.org; Thu, 21 Jul 2016 09:22:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vincent.legoll@gmail.com>) id 1bQDwC-0006S9-S6
	for guix-devel@gnu.org; Thu, 21 Jul 2016 09:22:53 -0400
In-Reply-To: <87y44vnpq3.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>, David Craven <david@craven.ch>

On Thu, Jul 21, 2016 at 2:24 PM, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
> David Craven <david@craven.ch> skribis:
>
>>> I think packages with a =E2=80=9Cbin=E2=80=9D output are not always use=
d as native
>>> inputs, so I would drop this rule.
>>
>> From searching the code-base we have I couldn't find a counter example. =
Do
>> you think it's ok to check for glib:bin specifically?
>
> Yes, sounds good to me.
>
> However, make sure to match on the package name + output, not on the
> label.  That is, =E2=80=98lint=E2=80=99 should correctly diagnose somethi=
ng like:
>
>   (inputs `(("somethingsilly" ,glib "bin")))

Yes, this is very important, as you have newbies coming now that try to
package software for guix and they don't understand what they are doing.

:-)

I was wondering the other day, what this "somethingsilly" string is for,
is it just a string or does it need to be a reference to something not sill=
y...

Looks like it's just a string, but...

I volunteer for reviewing error message, to see if they pass the low-level
schemer test... Just throw them at me !

--=20
Vincent Legoll