From: Vincent Legoll <vincent.legoll@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>, David Craven <david@craven.ch>
Subject: Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.
Date: Thu, 21 Jul 2016 15:22:50 +0200 [thread overview]
Message-ID: <CAEwRq=oEkabsVRBuxYAHqd3AXBJ-bA_Wi-W1ebh1UCYb3OeFXw@mail.gmail.com> (raw)
In-Reply-To: <87y44vnpq3.fsf@gnu.org>
On Thu, Jul 21, 2016 at 2:24 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Craven <david@craven.ch> skribis:
>
>>> I think packages with a “bin” output are not always used as native
>>> inputs, so I would drop this rule.
>>
>> From searching the code-base we have I couldn't find a counter example. Do
>> you think it's ok to check for glib:bin specifically?
>
> Yes, sounds good to me.
>
> However, make sure to match on the package name + output, not on the
> label. That is, ‘lint’ should correctly diagnose something like:
>
> (inputs `(("somethingsilly" ,glib "bin")))
Yes, this is very important, as you have newbies coming now that try to
package software for guix and they don't understand what they are doing.
:-)
I was wondering the other day, what this "somethingsilly" string is for,
is it just a string or does it need to be a reference to something not silly...
Looks like it's just a string, but...
I volunteer for reviewing error message, to see if they pass the low-level
schemer test... Just throw them at me !
--
Vincent Legoll
next prev parent reply other threads:[~2016-07-21 13:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 16:49 [PATCH 0/4] Dipping my toes into guix source David Craven
2016-07-19 16:49 ` [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native' David Craven
2016-07-20 10:37 ` Ludovic Courtès
2016-07-20 10:50 ` David Craven
2016-07-20 11:19 ` Efraim Flashner
2016-07-21 12:24 ` Ludovic Courtès
2016-07-21 13:22 ` Vincent Legoll [this message]
2016-07-21 16:06 ` Ludovic Courtès
2016-07-21 19:27 ` Tobias Geerinckx-Rice
2016-07-22 13:32 ` Ludovic Courtès
2016-07-22 14:07 ` Vincent Legoll
2016-07-19 16:49 ` [PATCH 2/4] gnu: Rename 'glib' label to 'glib:bin' where appropriate David Craven
2016-07-22 12:57 ` Ludovic Courtès
2016-07-22 13:03 ` David Craven
2016-07-22 17:55 ` David Craven
2016-07-19 16:49 ` [PATCH 3/4] lint: Add 'inputs-should-be-sorted' check David Craven
2016-07-21 13:17 ` Eric Bavier
2016-07-21 16:00 ` Ludovic Courtès
2016-07-19 16:49 ` [PATCH 4/4] environment: Add '--debug' flag David Craven
2016-07-19 17:14 ` Thompson, David
2016-07-19 18:00 ` Tobias Geerinckx-Rice
2016-07-19 18:10 ` David Craven
2016-07-19 19:02 ` David Craven
2016-07-19 19:06 ` Thompson, David
2016-07-19 19:15 ` David Craven
2016-07-20 4:17 ` Leo Famulari
2016-07-20 10:35 ` Ludovic Courtès
2016-07-20 10:56 ` David Craven
2016-07-19 20:11 ` Danny Milosavljevic
2016-07-20 7:18 ` Alex Kost
2016-07-20 7:35 ` Vincent Legoll
2016-07-20 9:15 ` Pjotr Prins
2016-07-22 19:54 ` Customising linux-libre (was: [PATCH 4/4] environment: Add '--debug' flag.) Tobias Geerinckx-Rice
2016-07-22 19:58 ` Vincent Legoll
2016-07-22 20:00 ` David Craven
2016-07-22 20:03 ` Vincent Legoll
2016-07-22 20:15 ` Customising linux-libre Tobias Geerinckx-Rice
2016-07-22 20:50 ` David Craven
2016-07-22 20:11 ` Tobias Geerinckx-Rice
2016-07-23 10:38 ` Ludovic Courtès
2016-07-21 12:22 ` [PATCH 4/4] environment: Add '--debug' flag Ludovic Courtès
2016-07-21 12:30 ` David Craven
2016-07-21 16:03 ` Ludovic Courtès
2016-07-21 16:12 ` David Craven
2016-07-21 16:38 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwRq=oEkabsVRBuxYAHqd3AXBJ-bA_Wi-W1ebh1UCYb3OeFXw@mail.gmail.com' \
--to=vincent.legoll@gmail.com \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).