From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Syme Subject: Re: [PATCH] gnu: Include CodingQuarry gene predictor Date: Tue, 08 Mar 2016 23:41:43 +0000 Message-ID: References: <20160308233937.GB24107@jasmine> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113f25dc3dc447052d92207c Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adRGE-0008Qx-OB for guix-devel@gnu.org; Tue, 08 Mar 2016 18:41:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adRGD-0003at-Oa for guix-devel@gnu.org; Tue, 08 Mar 2016 18:41:54 -0500 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]:36775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adRGD-0003ac-Iv for guix-devel@gnu.org; Tue, 08 Mar 2016 18:41:53 -0500 Received: by mail-io0-x230.google.com with SMTP id z76so46264674iof.3 for ; Tue, 08 Mar 2016 15:41:53 -0800 (PST) In-Reply-To: <20160308233937.GB24107@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org --001a113f25dc3dc447052d92207c Content-Type: text/plain; charset=UTF-8 Sure, I'll do that. Thanks for the feedback. -r On Wed, 9 Mar 2016, 07:40 Leo Famulari, wrote: > On Tue, Mar 08, 2016 at 05:13:34PM +0800, Rob Syme wrote: > > Thank you for the patch! > > > * gnu/packages/bioinformatics.scm: Add codingquarry package description > > When adding packages, we have a preferred format for the commit message. > It's either the GNU changelog format or a slightly modified version (I'm > not sure). You can see a good example in commit 0e2f2aebed. > > [...] > > > + (delete 'check) ;; Don't run the 'make check' step of the > > gnu-build-system > > When skippping the tests, we prefer to say why in the comment. It can be > as simple as "no test suite" if that is the case. > > [...] > > > + (native-inputs `(("python", python-2))) > > If the software only works with Python 2, I prefer to say so in a > comment such as "Only Python 2 is supported." I don't think is official > policy but I find it a useful piece of information to leave for other > readers. > > Can you submit a revised patch that addresses these issues? > --001a113f25dc3dc447052d92207c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Sure, I'll do that. Thanks for the feedback.
-r


On Wed, 9 Mar 2016, 07:40 L= eo Famulari, <leo@famulari.name= > wrote:
On Tue, Mar 08, 2016 at= 05:13:34PM +0800, Rob Syme wrote:

Thank you for the patch!

> * gnu/packages/bioinformatics.scm: Add codingquarry package descriptio= n

When adding packages, we have a preferred format for the commit message. It's either the GNU changelog format or a slightly modified version (I&= #39;m
not sure). You can see a good example in commit 0e2f2aebed.

[...]

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete 'check) ;; Don't ru= n the 'make check' step of the
> gnu-build-system

When skippping the tests, we prefer to say why in the comment. It can be as simple as "no test suite" if that is the case.

[...]

> +=C2=A0 =C2=A0 (native-inputs `(("python", python-2)))

If the software only works with Python 2, I prefer to say so in a
comment such as "Only Python 2 is supported." I don't think i= s official
policy but I find it a useful piece of information to leave for other
readers.

Can you submit a revised patch that addresses these issues?
--001a113f25dc3dc447052d92207c--